build/android/gyp/javac.py - Issue 869673002: Make javac.py assume UTF-8 encoding always

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/gyp/javac.py

Issue 869673002: Make javac.py assume UTF-8 encoding always (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/gyp/javac.py

diff --git a/build/android/gyp/javac.py b/build/android/gyp/javac.py

index 6a3024be33b4305832eed0a4d602f8f4becef499..15fe73db49827fed77692a61bd9aded108664d8d 100755

--- a/build/android/gyp/javac.py

+++ b/build/android/gyp/javac.py

@@ -72,6 +72,9 @@ def DoJavac(

javac_args = [

'-g',

+ # Chromium only allows UTF8 source files. Being explicit avoids

+ # javac pulling a default encoding from the user's environment.

+ '-encoding', 'UTF-8',

'-source', '1.7',

'-target', '1.7',

'-classpath', ':'.join(classpath),

« no previous file with comments | « no previous file | no next file » | no next file with comments »