VTTCue: Refactor display parameter handling

VTTCue: Refactor display parameter handling

Move VTTCue::m_display* into a separate struct (VTTDisplayParameters) and
let VTTCue::calculateDisplayParameters return said struct.
The returned struct is then passed to VTTCueBox for application.
Also drop VTTCue::m_computedLinePosition.
Also move the call to createVTTNodeTree out of calculateDisplayParameters
to allow marking the latter const.
The method VTTCue::getPositionCoordinates is folded into
calculateDisplayParameters.
Additional mark some methods const (calculateComputedLinePosition,
settingName), and drop the 'videoSize' argument from
TextTrackCue::updateDisplay (and callees) since it isn't used ATM.

BUG=301580
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188939

[fs, 2015-01-22 17:43:20]

fs@opera.com changed reviewers:
+ philipj@opera.com

[fs, 2015-01-22 17:43:21]

https://codereview.chromium.org/869623002/diff/1/Source/core/html/track/vtt/V...
File Source/core/html/track/vtt/VTTCue.cpp (right):

https://codereview.chromium.org/869623002/diff/1/Source/core/html/track/vtt/V...
Source/core/html/track/vtt/VTTCue.cpp:771: // FIXME: Remove this block.
Kept this block (from getPositionCoordinates) around for now to try and avoid
any behavioral changes in this CL. Intend to remove it in a follow up (need to
figure out how to update the single test that's affected.)

[philipj_slow, 2015-01-26 03:00:15]

The CQ bit was checked by philipj@opera.com

[philipj_slow, 2015-01-26 03:00:16]

lgtm

https://codereview.chromium.org/869623002/diff/1/Source/core/html/track/vtt/V...
File Source/core/html/track/vtt/VTTCue.cpp (right):

https://codereview.chromium.org/869623002/diff/1/Source/core/html/track/vtt/V...
Source/core/html/track/vtt/VTTCue.cpp:771: // FIXME: Remove this block.
On 2015/01/22 17:43:21, fs wrote:
> Kept this block (from getPositionCoordinates) around for now to try and avoid
> any behavioral changes in this CL. Intend to remove it in a follow up (need to
> figure out how to update the single test that's affected.)

Acknowledged.

[commit-bot: I haz the power, 2015-01-26 03:00:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/869623002/1

[commit-bot: I haz the power, 2015-01-26 03:03:30]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188939