Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Side by Side Diff: components/sessions/content/content_serialized_navigation_driver.cc

Issue 869613006: Move referrer policy to a different field when serializing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: updates Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/sessions/content/content_serialized_navigation_driver.h" 5 #include "components/sessions/content/content_serialized_navigation_driver.h"
6 6
7 #include "base/memory/singleton.h" 7 #include "base/memory/singleton.h"
8 #include "components/sessions/serialized_navigation_entry.h" 8 #include "components/sessions/serialized_navigation_entry.h"
9 #include "content/public/common/page_state.h" 9 #include "content/public/common/page_state.h"
10 #include "content/public/common/referrer.h" 10 #include "content/public/common/referrer.h"
(...skipping 15 matching lines...) Expand all
26 ContentSerializedNavigationDriver::ContentSerializedNavigationDriver() { 26 ContentSerializedNavigationDriver::ContentSerializedNavigationDriver() {
27 } 27 }
28 28
29 ContentSerializedNavigationDriver::~ContentSerializedNavigationDriver() { 29 ContentSerializedNavigationDriver::~ContentSerializedNavigationDriver() {
30 } 30 }
31 31
32 int ContentSerializedNavigationDriver::GetDefaultReferrerPolicy() const { 32 int ContentSerializedNavigationDriver::GetDefaultReferrerPolicy() const {
33 return blink::WebReferrerPolicyDefault; 33 return blink::WebReferrerPolicyDefault;
34 } 34 }
35 35
36 bool ContentSerializedNavigationDriver::MapReferrerPolicyToOldValues(
37 int referrer_policy,
38 int* mapped_referrer_policy) const {
39 // "always" and "default" are the same value in all versions.
40 if (referrer_policy == blink::WebReferrerPolicyAlways ||
Andrew T Wilson (Slow) 2015/01/29 11:02:13 This is fine, but I wonder if a case statement wou
41 referrer_policy == blink::WebReferrerPolicyDefault) {
42 *mapped_referrer_policy = referrer_policy;
43 return true;
44 }
45
46 // "origin" exists in the old encoding.
47 if (referrer_policy == blink::WebReferrerPolicyOrigin) {
48 *mapped_referrer_policy = 3;
49 return true;
50 }
51
52 // Everything else is mapped to never.
53 *mapped_referrer_policy = 2;
54 return false;
55 }
56
57 bool ContentSerializedNavigationDriver::MapReferrerPolicyToNewValues(
58 int referrer_policy,
59 int* mapped_referrer_policy) const {
60 // "always" and "default" are the same value in all versions.
61 if (referrer_policy == 0 || referrer_policy == 1) {
62 *mapped_referrer_policy = referrer_policy;
63 return true;
64 }
65
66 // Since we don't know what encoding was used, we map the rest to "never".
67 *mapped_referrer_policy = blink::WebReferrerPolicyNever;
68 return false;
69 }
70
36 std::string 71 std::string
37 ContentSerializedNavigationDriver::GetSanitizedPageStateForPickle( 72 ContentSerializedNavigationDriver::GetSanitizedPageStateForPickle(
38 const SerializedNavigationEntry* navigation) const { 73 const SerializedNavigationEntry* navigation) const {
39 if (!navigation->has_post_data_) { 74 if (!navigation->has_post_data_) {
40 return navigation->encoded_page_state_; 75 return navigation->encoded_page_state_;
41 } 76 }
42 content::PageState page_state = 77 content::PageState page_state =
43 content::PageState::CreateFromEncodedData( 78 content::PageState::CreateFromEncodedData(
44 navigation->encoded_page_state_); 79 navigation->encoded_page_state_);
45 return page_state.RemovePasswordData().ToEncodedData(); 80 return page_state.RemovePasswordData().ToEncodedData();
(...skipping 16 matching lines...) Expand all
62 navigation->referrer_policy_ = GetDefaultReferrerPolicy(); 97 navigation->referrer_policy_ = GetDefaultReferrerPolicy();
63 navigation->encoded_page_state_ = 98 navigation->encoded_page_state_ =
64 content::PageState::CreateFromEncodedData( 99 content::PageState::CreateFromEncodedData(
65 navigation->encoded_page_state_) 100 navigation->encoded_page_state_)
66 .RemoveReferrer() 101 .RemoveReferrer()
67 .ToEncodedData(); 102 .ToEncodedData();
68 } 103 }
69 } 104 }
70 105
71 } // namespace sessions 106 } // namespace sessions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698