Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Issue 869613005: Upgrade Blink to milliseconds-based last modified filetimes, part 7. (Closed)

Created:
5 years, 10 months ago by sof
Modified:
5 years, 10 months ago
Reviewers:
Mike West
CC:
blink-reviews, dglazkov+blink, kinuko+fileapi, nhiroki, tzik
Base URL:
https://chromium.googlesource.com/chromium/blink.git@sof-fileinfo-modtime-in-ms-5
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Upgrade Blink to milliseconds-based last modified filetimes, part 7. Remove WebFileInfo::modificationTimeMS, it is unused. This completes the transition of WebFileInfo::modificationTime to be milliseconds-based, and is the last patch in this series: 1: [blink] add WebFileInfo::modificationTimeMS [ https://codereview.chromium.org/873723004/ ] 2: [chromium] fill in modificationTimeMS [ https://codereview.chromium.org/884413002/ ] 3: [blink] make use of modificationTimeMS [ https://codereview.chromium.org/884393002/ ] 4: [chromium] set modificationTime to something msec-based [ https://codereview.chromium.org/862203003/ ] 5: [blink] switch to modificationTime [ https://codereview.chromium.org/882343002/ ] 6: [chromium] stop setting modificationTimeMS [ https://codereview.chromium.org/890523002/ ] 7: [blink] *this one* [ https://codereview.chromium.org/869613005/ ] R=mkwst BUG=451747 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189901

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M public/platform/WebFileInfo.h View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Mike West
LGTM \o/
5 years, 10 months ago (2015-01-30 08:19:11 UTC) #2
sof
On 2015/01/30 08:19:11, Mike West wrote: > LGTM \o/ Thanks all :) Let's do that ...
5 years, 10 months ago (2015-02-10 12:53:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/869613005/1
5 years, 10 months ago (2015-02-10 12:53:43 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-10 14:06:15 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189901

Powered by Google App Engine
This is Rietveld 408576698