Source/core/rendering/RenderMultiColumnFlowThread.h - Issue 869583002: [New Multicolumn] Support dynamic insertion and removal of multicol content.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderMultiColumnFlowThread.h

Issue 869583002: [New Multicolumn] Support dynamic insertion and removal of multicol content. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/multicol/dynamic/insert-block-before-spanner-before-content.html ('K') | « Source/core/rendering/RenderBox.cpp ('k') | Source/core/rendering/RenderMultiColumnFlowThread.cpp » ('j') | Source/core/rendering/RenderMultiColumnFlowThread.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderMultiColumnFlowThread.h

diff --git a/Source/core/rendering/RenderMultiColumnFlowThread.h b/Source/core/rendering/RenderMultiColumnFlowThread.h

index 1d9f67bdbebdf734c6916fd52866824f4ab26265..9660c9c58de4fbeb53d5df74a9ca2e2bcdd3be25 100644

--- a/Source/core/rendering/RenderMultiColumnFlowThread.h

+++ b/Source/core/rendering/RenderMultiColumnFlowThread.h

@@ -166,8 +166,8 @@ protected:

private:

void calculateColumnCountAndWidth(LayoutUnit& width, unsigned& count) const;

- void createAndInsertMultiColumnSet();

- void createAndInsertSpannerPlaceholder(RenderBox* spanner);

+ void createAndInsertMultiColumnSet(RenderBox* insertBefore = 0);

+ void createAndInsertSpannerPlaceholder(RenderBox* spanner, RenderBox* insertBefore = 0);

virtual bool descendantIsValidColumnSpanner(RenderObject* descendant) const;

virtual const char* renderName() const override;