Source/core/rendering/RenderBox.h - Issue 869583002: [New Multicolumn] Support dynamic insertion and removal of multicol content.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderBox.h

Issue 869583002: [New Multicolumn] Support dynamic insertion and removal of multicol content. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/multicol/dynamic/insert-block-before-spanner-before-content.html ('K') | « LayoutTests/fast/multicol/dynamic/spanner-in-content-becomes-regular-block-expected.html ('k') | Source/core/rendering/RenderBox.cpp » ('j') | Source/core/rendering/RenderMultiColumnFlowThread.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderBox.h

diff --git a/Source/core/rendering/RenderBox.h b/Source/core/rendering/RenderBox.h

index dc00c7f89411c0fe6cc4178bb8169ccff607539f..d1824296b68eb6bda5aef31ee579f98285f80e4a 100644

--- a/Source/core/rendering/RenderBox.h

+++ b/Source/core/rendering/RenderBox.h

@@ -651,7 +651,6 @@ public:

void setIntrinsicContentLogicalHeight(LayoutUnit intrinsicContentLogicalHeight) const { m_intrinsicContentLogicalHeight = intrinsicContentLogicalHeight; }

protected:

- virtual void willBeRemovedFromTree() override;

virtual void willBeDestroyed() override;

virtual void styleWillChange(StyleDifference, const RenderStyle& newStyle) override;