Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Issue 869573005: Implement posting location tracking in WebThread (Closed)

Created:
5 years, 11 months ago by Sami
Modified:
5 years, 11 months ago
Reviewers:
no sievers
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement posting location tracking in WebThread This patch adds two variants for postTask and postDelayedTask which take the original posting location as a parameter. This mirrors the similar task posting interface of base::TaskRunner and makes it possible to trace where tasks are being posted from. BUG=450977 Committed: https://crrev.com/2245d908d8d39bd6f8468ff5546f824fb60bf759 Cr-Commit-Position: refs/heads/master@{#313069}

Patch Set 1 #

Patch Set 2 : Build fix #

Patch Set 3 : Forward decl #

Total comments: 2

Patch Set 4 : make_scoped_ptr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -9 lines) Patch
M content/child/webthread_impl.h View 1 2 3 chunks +18 lines, -2 lines 0 comments Download
M content/child/webthread_impl.cc View 1 2 3 4 chunks +38 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Sami
5 years, 11 months ago (2015-01-22 20:52:11 UTC) #2
no sievers
lgtm https://codereview.chromium.org/869573005/diff/40001/content/child/webthread_impl.cc File content/child/webthread_impl.cc (right): https://codereview.chromium.org/869573005/diff/40001/content/child/webthread_impl.cc#newcode114 content/child/webthread_impl.cc:114: base::Bind(RunWebThreadTask, base::Passed(scoped_ptr<Task>(task))), nit: make_scoped_ptr
5 years, 11 months ago (2015-01-23 20:39:47 UTC) #3
Sami
https://codereview.chromium.org/869573005/diff/40001/content/child/webthread_impl.cc File content/child/webthread_impl.cc (right): https://codereview.chromium.org/869573005/diff/40001/content/child/webthread_impl.cc#newcode114 content/child/webthread_impl.cc:114: base::Bind(RunWebThreadTask, base::Passed(scoped_ptr<Task>(task))), On 2015/01/23 20:39:47, sievers wrote: > nit: ...
5 years, 11 months ago (2015-01-26 13:41:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/869573005/60001
5 years, 11 months ago (2015-01-26 13:42:29 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 11 months ago (2015-01-26 15:01:14 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-26 15:03:11 UTC) #8
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/2245d908d8d39bd6f8468ff5546f824fb60bf759
Cr-Commit-Position: refs/heads/master@{#313069}

Powered by Google App Engine
This is Rietveld 408576698