[Mac] Allow vibrancy & transparency on WebContentsView

[Mac] Allow vibrancy & transparency on WebContentsView

In order to make a view vibrant we need to:
1. Place the view inside NSVisualEffectView
2. Return YES from allowsVibrancy

In order to make it possible to use WebContentsViewCocoa in vibrant view hierarchy, we need to implement allowsVibrancy.

From NSView documentation for allowsVibrancy:
"AppKit checks this property when the view is incorporated into a view hierarchy that uses vibrancy."

This means that only returning YES from allowsVibrancy will have no effect on the way view is rendered, we are safe to just return YES here.

Note: returning YES from isOpaque causes problems with vibrancy, that is why a setter is needed on RenderWidgetHostViewCocoa.

Committed: https://crrev.com/9b7defaa80bca9d488021c36df27fc94ef446496
Cr-Commit-Position: refs/heads/master@{#316210}

[joleksy, 2015-01-22 14:53:12]

joleksy@opera.com changed reviewers:
+ asvitkine@chromium.org

[joleksy, 2015-01-22 14:54:28]

@reviewer: does it look OK to you?

[Alexei Svitkine (slow), 2015-01-22 16:41:22]

https://codereview.chromium.org/869563003/diff/1/content/browser/web_contents...
File content/browser/web_contents/web_contents_view_mac.mm (right):

https://codereview.chromium.org/869563003/diff/1/content/browser/web_contents...
content/browser/web_contents/web_contents_view_mac.mm:427: return YES;
What's the effect of returning YES here?

Does it change behavior by default or is it dependent on something else? (e.g.
the view being opaque)

If it doesn't change anything on its own, please document that here in a
comment.

(If it does change things, then probably we should make it configurable unless
Chrome decides to actually adopt the changed behavior/appearance.)

[joleksy, 2015-01-23 07:24:01]

https://codereview.chromium.org/869563003/diff/1/content/browser/web_contents...
File content/browser/web_contents/web_contents_view_mac.mm (right):

https://codereview.chromium.org/869563003/diff/1/content/browser/web_contents...
content/browser/web_contents/web_contents_view_mac.mm:427: return YES;
On 2015/01/22 16:41:21, Alexei Svitkine wrote:
> What's the effect of returning YES here?
> 
> Does it change behavior by default or is it dependent on something else? (e.g.
> the view being opaque)
> 
> If it doesn't change anything on its own, please document that here in a
> comment.
> 
> (If it does change things, then probably we should make it configurable unless
> Chrome decides to actually adopt the changed behavior/appearance.)

By itself it does not change anything, from the documentation:
"AppKit checks this property when the view is incorporated into a view hierarchy
that uses vibrancy."
This means that in order to actually change how this view looks it would have to
be put inside a vibrant hierarchy (i.e. within NSVisualEffectView).
I will add comment.

[Alexei Svitkine (slow), 2015-01-23 14:54:38]

lgtm

[joleksy, 2015-01-23 15:02:39]

The CQ bit was checked by joleksy@opera.com

[commit-bot: I haz the power, 2015-01-23 15:03:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/869563003/20001

[commit-bot: I haz the power, 2015-01-23 15:12:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-23 15:12:41]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[joleksy, 2015-01-26 07:28:49]

joleksy@opera.com changed reviewers:
+ pinkerton@chromium.org

[joleksy, 2015-01-26 07:30:01]

On 2015/01/23 15:12:41, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on tryserver.chromium.linux
>
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

Missing LGTM from the owner of web_contents_view_mac.mm.

@pink: could you take a look?

[pink (ping after 24hrs), 2015-01-26 12:46:31]

pinkerton@chromium.org changed reviewers:
+ ccameron@chromium.org

[pink (ping after 24hrs), 2015-01-26 12:46:32]

ccameron should be the one to take a look at this. I'm also concerned about the
general perf impact.

[joleksy, 2015-01-26 15:36:53]

On 2015/01/26 12:46:32, pink wrote:
> ccameron should be the one to take a look at this. I'm also concerned about
the
> general perf impact.

The perf impact *should* be none (according to Cocoa documentation), this
property is taken into account only if the view is inside vibrant view
hierarchy.

[joleksy, 2015-02-06 07:34:30]

On 2015/01/26 15:36:53, joleksy wrote:
> On 2015/01/26 12:46:32, pink wrote:
> > ccameron should be the one to take a look at this. I'm also concerned about
> the
> > general perf impact.
> 
> The perf impact *should* be none (according to Cocoa documentation), this
> property is taken into account only if the view is inside vibrant view
> hierarchy.

Anyone?

[ccameron, 2015-02-09 23:44:24]

This lgtm, since the default will be no change.

[joleksy, 2015-02-10 08:02:32]

The CQ bit was checked by joleksy@opera.com

[commit-bot: I haz the power, 2015-02-10 08:03:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/869563003/20001

[commit-bot: I haz the power, 2015-02-10 08:08:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-10 08:08:05]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[joleksy, 2015-02-10 08:52:53]

On 2015/02/10 08:08:05, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

I got:
Missing LGTM from an OWNER for these files:
    content/browser/web_contents/web_contents_view_mac.h
    content/browser/web_contents/web_contents_view_mac.mm

@ccameron: I thought it was you, do you know what the problem is?

[ccameron, 2015-02-10 09:18:51]

On 2015/02/10 08:52:53, joleksy wrote:
> On 2015/02/10 08:08:05, I haz the power (commit-bot) wrote:
> > Try jobs failed on following builders:
> >   chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
> 
> I got:
> Missing LGTM from an OWNER for these files:
>     content/browser/web_contents/web_contents_view_mac.h
>     content/browser/web_contents/web_contents_view_mac.mm
> 
> @ccameron: I thought it was you, do you know what the problem is?

I don't have web_contents -- just renderer_host and compositor. The only Mac
OWNER for content/ is avi@

I should add myself as an owner of web_contents as well.

[joleksy, 2015-02-10 09:54:23]

joleksy@opera.com changed reviewers:
+ avi@chromium.org

[joleksy, 2015-02-10 09:54:52]

On 2015/02/10 09:18:51, ccameron wrote:
> On 2015/02/10 08:52:53, joleksy wrote:
> > On 2015/02/10 08:08:05, I haz the power (commit-bot) wrote:
> > > Try jobs failed on following builders:
> > >   chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
> > >
> >
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
> > 
> > I got:
> > Missing LGTM from an OWNER for these files:
> >     content/browser/web_contents/web_contents_view_mac.h
> >     content/browser/web_contents/web_contents_view_mac.mm
> > 
> > @ccameron: I thought it was you, do you know what the problem is?
> 
> I don't have web_contents -- just renderer_host and compositor. The only Mac
> OWNER for content/ is avi@
> 
> I should add myself as an owner of web_contents as well.

Thanks!

Added avi@.

@avi: could you take a look?

[Avi (use Gerrit), 2015-02-10 15:42:22]

I'm down with it.

LGTM

[joleksy, 2015-02-13 13:12:03]

The CQ bit was checked by joleksy@opera.com

[commit-bot: I haz the power, 2015-02-13 13:12:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/869563003/20001

[commit-bot: I haz the power, 2015-02-13 13:18:51]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-13 13:19:33]

Patchset 2 (id:??) landed as
https://crrev.com/9b7defaa80bca9d488021c36df27fc94ef446496
Cr-Commit-Position: refs/heads/master@{#316210}