Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1024)

Issue 869563003: [Mac] Allow vibrancy & transparency on WebContentsView (Closed)

Created:
5 years, 11 months ago by joleksy
Modified:
5 years, 10 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Allow vibrancy & transparency on WebContentsView In order to make a view vibrant we need to: 1. Place the view inside NSVisualEffectView 2. Return YES from allowsVibrancy In order to make it possible to use WebContentsViewCocoa in vibrant view hierarchy, we need to implement allowsVibrancy. From NSView documentation for allowsVibrancy: "AppKit checks this property when the view is incorporated into a view hierarchy that uses vibrancy." This means that only returning YES from allowsVibrancy will have no effect on the way view is rendered, we are safe to just return YES here. Note: returning YES from isOpaque causes problems with vibrancy, that is why a setter is needed on RenderWidgetHostViewCocoa. Committed: https://crrev.com/9b7defaa80bca9d488021c36df27fc94ef446496 Cr-Commit-Position: refs/heads/master@{#316210}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add comment to [WebContentsViewCocoa allowsVibrancy] #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -1 line) Patch
M content/browser/renderer_host/render_widget_host_view_mac.h View 2 chunks +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 3 chunks +6 lines, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_mac.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_view_mac.mm View 1 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 29 (9 generated)
joleksy
@reviewer: does it look OK to you?
5 years, 11 months ago (2015-01-22 14:54:28 UTC) #2
Alexei Svitkine (slow)
https://codereview.chromium.org/869563003/diff/1/content/browser/web_contents/web_contents_view_mac.mm File content/browser/web_contents/web_contents_view_mac.mm (right): https://codereview.chromium.org/869563003/diff/1/content/browser/web_contents/web_contents_view_mac.mm#newcode427 content/browser/web_contents/web_contents_view_mac.mm:427: return YES; What's the effect of returning YES here? ...
5 years, 11 months ago (2015-01-22 16:41:22 UTC) #3
joleksy
https://codereview.chromium.org/869563003/diff/1/content/browser/web_contents/web_contents_view_mac.mm File content/browser/web_contents/web_contents_view_mac.mm (right): https://codereview.chromium.org/869563003/diff/1/content/browser/web_contents/web_contents_view_mac.mm#newcode427 content/browser/web_contents/web_contents_view_mac.mm:427: return YES; On 2015/01/22 16:41:21, Alexei Svitkine wrote: > ...
5 years, 11 months ago (2015-01-23 07:24:01 UTC) #4
Alexei Svitkine (slow)
lgtm
5 years, 11 months ago (2015-01-23 14:54:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/869563003/20001
5 years, 11 months ago (2015-01-23 15:03:45 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/37923)
5 years, 11 months ago (2015-01-23 15:12:41 UTC) #9
joleksy
On 2015/01/23 15:12:41, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
5 years, 11 months ago (2015-01-26 07:30:01 UTC) #11
pink (ping after 24hrs)
ccameron should be the one to take a look at this. I'm also concerned about ...
5 years, 11 months ago (2015-01-26 12:46:32 UTC) #13
joleksy
On 2015/01/26 12:46:32, pink wrote: > ccameron should be the one to take a look ...
5 years, 10 months ago (2015-01-26 15:36:53 UTC) #14
joleksy
On 2015/01/26 15:36:53, joleksy wrote: > On 2015/01/26 12:46:32, pink wrote: > > ccameron should ...
5 years, 10 months ago (2015-02-06 07:34:30 UTC) #15
ccameron
This lgtm, since the default will be no change.
5 years, 10 months ago (2015-02-09 23:44:24 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/869563003/20001
5 years, 10 months ago (2015-02-10 08:03:24 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/41641)
5 years, 10 months ago (2015-02-10 08:08:05 UTC) #20
joleksy
On 2015/02/10 08:08:05, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
5 years, 10 months ago (2015-02-10 08:52:53 UTC) #21
ccameron
On 2015/02/10 08:52:53, joleksy wrote: > On 2015/02/10 08:08:05, I haz the power (commit-bot) wrote: ...
5 years, 10 months ago (2015-02-10 09:18:51 UTC) #22
joleksy
On 2015/02/10 09:18:51, ccameron wrote: > On 2015/02/10 08:52:53, joleksy wrote: > > On 2015/02/10 ...
5 years, 10 months ago (2015-02-10 09:54:52 UTC) #24
Avi (use Gerrit)
I'm down with it. LGTM
5 years, 10 months ago (2015-02-10 15:42:22 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/869563003/20001
5 years, 10 months ago (2015-02-13 13:12:56 UTC) #27
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-13 13:18:51 UTC) #28
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 13:19:33 UTC) #29
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9b7defaa80bca9d488021c36df27fc94ef446496
Cr-Commit-Position: refs/heads/master@{#316210}

Powered by Google App Engine
This is Rietveld 408576698