dart2js: store fields in the model and make the emitters use it.

pkg/compiler/lib/src/js_emitter/model.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dart2js.new_js_emitter.model;
 
 import '../js/js.dart' as js show Expression;
 import '../constants/values.dart' show ConstantValue;
 
 import '../deferred_load.dart' show OutputUnit;
@@ skipping 112 matching lines @@
 }
 
 class Constant {
   final String name;
   final Holder holder;
   final ConstantValue value;
 
   Constant(this.name, this.holder, this.value);
 }
 
-class Library {
+abstract class FieldContainer {
+  List<Field> get staticFieldsForReflection;
+}
+
+class Library implements FieldContainer {
   /// The element should only be used during the transition to the new model.
   /// Uses indicate missing information in the model.
   final Element element;
 
   final String uri;
   final List<StaticMethod> statics;
   final List<Class> classes;
 
-  Library(this.element, this.uri, this.statics, this.classes);
+  final List<Field> staticFieldsForReflection;
+
+  Library(this.element, this.uri, this.statics, this.classes,
+          this.staticFieldsForReflection);
 }
 
 class StaticField {
   /// The element should only be used during the transition to the new model.
   /// Uses indicate missing information in the model.
   final Element element;
 
   final String name;
   // TODO(floitsch): the holder for static fields is the isolate object. We
   // could remove this field and use the isolate object directly.
   final Holder holder;
   final js.Expression code;
   final bool isFinal;
   final bool isLazy;
 
   StaticField(this.element,
               this.name, this.holder, this.code,
               this.isFinal, this.isLazy);
 }
 
-class Class {
+class Class implements FieldContainer {
   /// The element should only be used during the transition to the new model.
   /// Uses indicate missing information in the model.
   final Element element;
 
   final String name;
   final Holder holder;
   Class _superclass;
   final List<Method> methods;
-  final List<InstanceField> fields;
+  final List<Field> fields;
   final List<StubMethod> isChecks;
+  final List<Field> staticFieldsForReflection;
   final bool onlyForRti;
   final bool isDirectlyInstantiated;
   final bool isNative;
 
   // If the class implements a function type, and the type is encoded in the
   // metatada table, then this field contains the index into that field.
   final int functionTypeIndex;
 
   /// Whether the class must be evaluated eagerly.
   bool isEager = false;
 
   Class(this.element, this.name, this.holder,
         this.methods,
         this.fields,
+        this.staticFieldsForReflection,
         this.isChecks,
         this.functionTypeIndex,
         {this.onlyForRti,
          this.isDirectlyInstantiated,
          this.isNative}) {
     assert(onlyForRti != null);
     assert(isDirectlyInstantiated != null);
     assert(isNative != null);
   }
 
   bool get isMixinApplication => false;
   Class get superclass => _superclass;
 
   void setSuperclass(Class superclass) {
     _superclass = superclass;
   }
 
   String get superclassName
       => (superclass == null) ? "" : superclass.name;
   int get superclassHolderIndex
       => (superclass == null) ? 0 : superclass.holder.index;
 }
 
 class MixinApplication extends Class {
   Class _mixinClass;
 
   MixinApplication(Element element, String name, Holder holder,
+                   List<Field> instanceFields,
+                   List<Field> staticFieldsForReflection,
                    List<StubMethod> isChecks,
                    int functionTypeIndex,
                    {bool onlyForRti,
                     bool isDirectlyInstantiated})
       : super(element,
               name, holder,
-              const <Method>[], const <InstanceField>[],
+              const <Method>[],
+              instanceFields,
+              staticFieldsForReflection,
               isChecks, functionTypeIndex,
               onlyForRti: onlyForRti,
               isDirectlyInstantiated: isDirectlyInstantiated,
               isNative: false);
 
   bool get isMixinApplication => true;
   Class get mixinClass => _mixinClass;
 
   void setMixinClass(Class mixinClass) {
     _mixinClass = mixinClass;
   }
 }
 
-class InstanceField {
+/// A field.
+///
+/// In general represents an instance field, but for reflection may also
+/// represent static fields.
+class Field {
   /// The element should only be used during the transition to the new model.
   /// Uses indicate missing information in the model.
   final Element element;
 
   final String name;
+  final String accessorName;
 
   /// 00: Does not need any getter.
   /// 01:  function() { return this.field; }
   /// 10:  function(receiver) { return receiver.field; }
   /// 11:  function(receiver) { return this.field; }
   final int getterFlags;
 
   /// 00: Does not need any setter.
   /// 01:  function(value) { this.field = value; }
   /// 10:  function(receiver, value) { receiver.field = value; }
   /// 11:  function(receiver, value) { this.field = value; }
   final int setterFlags;
 
+  final bool needsCheckedSetter;
+
   // TODO(floitsch): support renamed fields.
-  InstanceField(this.element, this.name, this.getterFlags, this.setterFlags);
+  Field(this.element, this.name, this.accessorName,
+        this.getterFlags, this.setterFlags,
+        this.needsCheckedSetter);
 
   bool get needsGetter => getterFlags != 0;
-  bool get needsSetter => setterFlags != 0;
+  bool get needsUncheckedSetter => setterFlags != 0;
+
+  bool get needsInterceptedGetter => getterFlags > 1;
+  bool get needsInterceptedSetter => setterFlags > 1;
 }
 
 class Method {
   /// The element should only be used during the transition to the new model.
   /// Uses indicate missing information in the model.
   final Element element;
 
   final String name;
   final js.Expression code;
   final bool needsTearOff;
@@ skipping 13 matching lines @@
   StaticMethod(Element element, String name, this.holder, js.Expression code,
                {bool needsTearOff})
       : super(element, name, code, needsTearOff: needsTearOff);
 }
 
 class StaticStubMethod extends StaticMethod {
   StaticStubMethod(String name, Holder holder, js.Expression code,
                    {bool needsTearOff})
       : super(null, name, holder, code, needsTearOff: needsTearOff);
 }