content/public/test/web_contents_observer_sanity_checker.h - Issue 869533004: Fix WCO::RenderFrameCreated and WCO::RenderFrameDeleted notifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/test/web_contents_observer_sanity_checker.h

Issue 869533004: Fix WCO::RenderFrameCreated and WCO::RenderFrameDeleted notifications. Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixes for RenderFrameHostChanged. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/web_contents/web_contents_impl_unittest.cc ('k') | content/public/test/web_contents_observer_sanity_checker.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/test/web_contents_observer_sanity_checker.h

diff --git a/content/public/test/web_contents_observer_sanity_checker.h b/content/public/test/web_contents_observer_sanity_checker.h

index 2d702d0859e34184f694cf7fd666279e6be5fc3d..a26b44e5f3c6e7012e80d5a47e43ef58af4a6574 100644

--- a/content/public/test/web_contents_observer_sanity_checker.h

+++ b/content/public/test/web_contents_observer_sanity_checker.h

@@ -84,11 +84,17 @@ class WebContentsObserverSanityChecker : public WebContentsObserver,

~WebContentsObserverSanityChecker() override;

std::string Format(RenderFrameHost* render_frame_host);

- void AssertFrameExists(RenderFrameHost* render_frame_host);

+ void AssertRenderFrameHostExists(RenderFrameHost* render_frame_host);

+ void AssertRenderFrameExists(RenderFrameHost* render_frame_host);

void AssertMainFrameExists();

+ std::set<std::pair<int, int>> current_hosts_;

+ std::set<std::pair<int, int>> deleted_hosts_;

std::set<std::pair<int, int>> live_routes_;

std::set<std::pair<int, int>> deleted_routes_;

+ base::hash_map<std::pair<int, int>, std::string> render_frame_created_stacks_;

+ base::hash_map<std::pair<int, int>, std::string> render_frame_deleted_stacks_;

bool web_contents_destroyed_;

DISALLOW_COPY_AND_ASSIGN(WebContentsObserverSanityChecker);