Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Unified Diff: content/browser/frame_host/frame_tree_unittest.cc

Issue 869533004: Fix WCO::RenderFrameCreated and WCO::RenderFrameDeleted notifications. Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixes for RenderFrameHostChanged. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/frame_host/render_frame_host_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/frame_tree_unittest.cc
diff --git a/content/browser/frame_host/frame_tree_unittest.cc b/content/browser/frame_host/frame_tree_unittest.cc
index 6ee69fc52b7e1bbc8e8d7bb9048e0324e637a03a..18abeb6c8150a2dd142b1122a58c840d209739c6 100644
--- a/content/browser/frame_host/frame_tree_unittest.cc
+++ b/content/browser/frame_host/frame_tree_unittest.cc
@@ -84,6 +84,7 @@ class TreeWalkingWebContentsLogger : public WebContentsObserver {
private:
void LogWhatHappened(const std::string& event_name) {
+ LOG(ERROR) << "LogWhatHappened: |" << event_name << "|";
if (!log_.empty()) {
log_.append("\n");
}
@@ -229,11 +230,13 @@ TEST_F(FrameTreeTest, ObserverWalksTreeAfterCrash) {
EXPECT_EQ("RenderFrameCreated(23) -> 1: [22: [], 23: []]", activity.GetLog());
// Crash the renderer
- main_rfh()->OnMessageReceived(FrameHostMsg_RenderProcessGone(
- 0, base::TERMINATION_STATUS_PROCESS_CRASHED, -1));
+ main_test_rfh()->OnMessageReceived(FrameHostMsg_RenderProcessGone(
+ main_test_rfh()->GetRoutingID(), base::TERMINATION_STATUS_PROCESS_CRASHED,
+ -1));
EXPECT_EQ(
"RenderFrameDeleted(22) -> 1: []\n"
"RenderFrameDeleted(23) -> 1: []\n"
+ "RenderFrameDeleted(1) -> 1: []\n"
"RenderProcessGone -> 1: []",
activity.GetLog());
}
« no previous file with comments | « no previous file | content/browser/frame_host/render_frame_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698