Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 869513005: Tweak and repurpose code caching options. (Closed)

Created:
5 years, 10 months ago by Yang
Modified:
5 years, 10 months ago
CC:
arv+blink, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Tweak and repurpose code caching options. - Removed lower and upper source size limit for code caching. - *Small and *Mobile options turn on compression. - HeuristicsDefault* options cache on first occurrence. - Recent* options cache on second occurrence within 36 hours. - Heuristics* options cache on second occurrence within 72 hours. - Added V8.CodeCacheSizeRatio histogram to track code cache overhead. BUG=chromium:399580 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189511

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -39 lines) Patch
M Source/bindings/core/v8/V8ScriptRunner.cpp View 5 chunks +23 lines, -39 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Yang
Offline discussion concluded that we definitely want to get rid of the upper size limit ...
5 years, 10 months ago (2015-02-04 12:57:27 UTC) #2
vogelheim
lgtm
5 years, 10 months ago (2015-02-04 13:16:00 UTC) #4
jochen (gone - plz use gerrit)
lgtm
5 years, 10 months ago (2015-02-04 13:24:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/869513005/1
5 years, 10 months ago (2015-02-04 13:25:39 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 16:20:52 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189511

Powered by Google App Engine
This is Rietveld 408576698