SuspendableScriptExecutor executes code once

SuspendableScriptExecutor executes code once

When executor runs blocking code for example call alert. It receives more then one resume call and without this CL try execute code more then once.

R=pfeldman@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189626

[kozy, 2015-02-04 11:41:07]

Pavel, please take a look.

[pfeldman, 2015-02-04 12:45:20]

https://codereview.chromium.org/869513004/diff/1/Source/web/SuspendableScript...
File Source/web/SuspendableScriptExecutor.cpp (right):

https://codereview.chromium.org/869513004/diff/1/Source/web/SuspendableScript...
Source/web/SuspendableScriptExecutor.cpp:27: if (!m_isStarted)
This implies that the code containing alert will affect the order of execution

...
alert()
  <--- resume will be fired here.
...

[kozy, 2015-02-04 13:12:33]

please take a look

https://codereview.chromium.org/869513004/diff/1/Source/web/SuspendableScript...
File Source/web/SuspendableScriptExecutor.cpp (right):

https://codereview.chromium.org/869513004/diff/1/Source/web/SuspendableScript...
Source/web/SuspendableScriptExecutor.cpp:27: if (!m_isStarted)
On 2015/02/04 12:45:20, pfeldman wrote:
> This implies that the code containing alert will affect the order of execution
> 
> ...
> alert()
>   <--- resume will be fired here.
> ...
> 

Fixed.

[kozy, 2015-02-05 09:02:49]

SupendableScriptExecutor inherits SuspendableTimer instead ActiveDOMObject. In
run method we call execute if context is not suspended otherwise start timer and
suspend it if needed.

[pfeldman, 2015-02-05 13:49:42]

https://codereview.chromium.org/869513004/diff/40001/Source/web/SuspendableSc...
File Source/web/SuspendableScriptExecutor.cpp (right):

https://codereview.chromium.org/869513004/diff/40001/Source/web/SuspendableSc...
Source/web/SuspendableScriptExecutor.cpp:59: suspendIfNeeded();
Why do you make this call?

[kozy, 2015-02-05 14:58:26]

https://codereview.chromium.org/869513004/diff/40001/Source/web/SuspendableSc...
File Source/web/SuspendableScriptExecutor.cpp (right):

https://codereview.chromium.org/869513004/diff/40001/Source/web/SuspendableSc...
Source/web/SuspendableScriptExecutor.cpp:59: suspendIfNeeded();
On 2015/02/05 13:49:42, pfeldman wrote:
> Why do you make this call?

We can remove it. Removed.

[pfeldman, 2015-02-05 19:52:21]

lgtm

[kozy, 2015-02-05 19:52:57]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2015-02-05 19:53:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/869513004/60001

[pfeldman, 2015-02-05 19:55:49]

lgtm

[commit-bot: I haz the power, 2015-02-05 21:54:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-05 21:54:30]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/49513)

[kozy, 2015-02-06 07:13:09]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2015-02-06 07:13:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/869513004/60001

[commit-bot: I haz the power, 2015-02-06 08:50:08]

Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189626