Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Unified Diff: pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart

Issue 869513003: dart2js: Move metadata from old_emitter to shared directory. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart
diff --git a/pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart b/pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart
index e79e424e656d1975df979157d4d2a51211ad82eb..18c8acf8980afee372ebb7641a4e1c39b22c04c8 100644
--- a/pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart
+++ b/pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart
@@ -472,7 +472,7 @@ class ContainerBuilder extends CodeEmitterHelper {
backend.rti.getSignatureEncoding(memberType, thisAccess);
} else {
memberTypeExpression =
- js.number(emitter.metadataEmitter.reifyType(memberType));
+ js.number(task.metadataEmitter.reifyType(memberType));
}
} else {
memberTypeExpression = js('null');
@@ -485,20 +485,20 @@ class ContainerBuilder extends CodeEmitterHelper {
..add(js.number(requiredParameterCount))
..add(js.number(optionalParameterCount))
..add(memberTypeExpression)
- ..addAll(emitter.metadataEmitter
+ ..addAll(task.metadataEmitter
.reifyDefaultArguments(member).map(js.number));
if (canBeReflected || canBeApplied) {
parameters.forEachParameter((Element parameter) {
expressions.add(
- js.number(emitter.metadataEmitter.reifyName(parameter.name)));
+ js.number(task.metadataEmitter.reifyName(parameter.name)));
if (backend.mustRetainMetadata) {
Iterable<int> metadataIndices =
parameter.metadata.map((MetadataAnnotation annotation) {
ConstantValue constant =
backend.constants.getConstantForMetadata(annotation).value;
backend.constants.addCompileTimeConstantForEmission(constant);
- return emitter.metadataEmitter.reifyMetadata(annotation);
+ return task.metadataEmitter.reifyMetadata(annotation);
});
expressions.add(new jsAst.ArrayInitializer(
metadataIndices.map(js.number).toList()));
@@ -518,8 +518,7 @@ class ContainerBuilder extends CodeEmitterHelper {
}
expressions
..add(reflectionName)
- ..addAll(emitter.metadataEmitter
- .computeMetadata(member).map(js.number));
+ ..addAll(task.metadataEmitter.computeMetadata(member).map(js.number));
} else if (isClosure && canBeApplied) {
expressions.add(js.string(namer.privateName(member.library,
member.name)));

Powered by Google App Engine
This is Rietveld 408576698