Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart

Issue 869513003: dart2js: Move metadata from old_emitter to shared directory. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart
diff --git a/pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart b/pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart
index 6e5b46d38222b18f527f7e256bb967cbf7f24e35..01d86db1b29d13e463dcb7e4424e0f3b066c1030 100644
--- a/pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart
+++ b/pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart
@@ -118,8 +118,7 @@ class ClassEmitter extends CodeEmitterHelper {
// accessors at runtime.
bool needsFieldsForConstructor = !emitStatics && !classIsNative;
if (needsFieldsForConstructor || needsAccessor) {
- var metadata =
- emitter.metadataEmitter.buildMetadataFunction(fieldElement);
+ var metadata = task.metadataEmitter.buildMetadataFunction(fieldElement);
if (metadata != null) {
hasMetadata = true;
} else {
@@ -163,7 +162,7 @@ class ClassEmitter extends CodeEmitterHelper {
}
if (backend.isAccessibleByReflection(fieldElement)) {
DartType type = fieldElement.type;
- reflectionMarker = '-${emitter.metadataEmitter.reifyType(type)}';
+ reflectionMarker = '-${task.metadataEmitter.reifyType(type)}';
}
String builtFieldname = '$fieldName$fieldCode$reflectionMarker';
builder.addField(builtFieldname);
@@ -279,7 +278,7 @@ class ClassEmitter extends CodeEmitterHelper {
ClassElement classElement = cls.element;
String className = cls.name;
- var metadata = emitter.metadataEmitter.buildMetadataFunction(classElement);
+ var metadata = task.metadataEmitter.buildMetadataFunction(classElement);
if (metadata != null) {
classBuilder.addProperty("@", metadata);
}
@@ -332,10 +331,10 @@ class ClassEmitter extends CodeEmitterHelper {
} else {
List<int> types = <int>[];
if (classElement.supertype != null) {
- types.add(emitter.metadataEmitter.reifyType(classElement.supertype));
+ types.add(task.metadataEmitter.reifyType(classElement.supertype));
}
for (DartType interface in classElement.interfaces) {
- types.add(emitter.metadataEmitter.reifyType(interface));
+ types.add(task.metadataEmitter.reifyType(interface));
}
enclosingBuilder.addProperty("+$reflectionName",
new jsAst.ArrayInitializer(types.map(js.number).toList()));

Powered by Google App Engine
This is Rietveld 408576698