Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 869463002: remove (unused) GatherPixelRefs (Closed)

Created:
5 years, 11 months ago by reed2
Modified:
5 years, 11 months ago
Reviewers:
robertphillips, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

remove (unused) GatherPixelRefs BUG=skia: Committed: https://skia.googlesource.com/skia/+/b0dfb546f5e731d2a5da9479f41b00296e1ba082

Patch Set 1 #

Patch Set 2 : #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1254 lines) Patch
M gyp/utils.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download
M include/utils/SkPictureUtils.h View 1 chunk +0 lines, -67 lines 0 comments Download
D src/utils/SkGatherPixelRefsAndRects.h View 1 1 chunk +0 lines, -319 lines 0 comments Download
D src/utils/SkGatherPixelRefsAndRects.cpp View 1 1 chunk +0 lines, -25 lines 0 comments Download
M src/utils/SkPictureUtils.cpp View 1 chunk +0 lines, -202 lines 0 comments Download
M tests/PictureTest.cpp View 1 5 chunks +0 lines, -598 lines 4 comments Download
M tools/PictureRenderer.cpp View 1 chunk +0 lines, -35 lines 0 comments Download
M tools/PictureRenderingFlags.cpp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
reed2
5 years, 11 months ago (2015-01-22 12:59:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/869463002/20001
5 years, 11 months ago (2015-01-22 12:59:36 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 11 months ago (2015-01-22 12:59:37 UTC) #5
robertphillips
lgtm + maybe a bit more to delete https://codereview.chromium.org/869463002/diff/20001/tests/PictureTest.cpp File tests/PictureTest.cpp (left): https://codereview.chromium.org/869463002/diff/20001/tests/PictureTest.cpp#oldcode81 tests/PictureTest.cpp:81: Remove ...
5 years, 11 months ago (2015-01-22 15:37:05 UTC) #6
reed1
https://codereview.chromium.org/869463002/diff/20001/tests/PictureTest.cpp File tests/PictureTest.cpp (left): https://codereview.chromium.org/869463002/diff/20001/tests/PictureTest.cpp#oldcode81 tests/PictureTest.cpp:81: On 2015/01/22 15:37:05, robertphillips wrote: > Remove this? Will ...
5 years, 11 months ago (2015-01-22 17:02:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/869463002/20001
5 years, 11 months ago (2015-01-22 17:03:14 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-22 17:03:28 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/b0dfb546f5e731d2a5da9479f41b00296e1ba082

Powered by Google App Engine
This is Rietveld 408576698