Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(851)

Unified Diff: chrome/browser/ui/views/toolbar/toolbar_action_view.h

Issue 869453002: Define class names for views class in c/b/ui/views (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: addressed comments Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/toolbar/toolbar_action_view.h
diff --git a/chrome/browser/ui/views/toolbar/toolbar_action_view.h b/chrome/browser/ui/views/toolbar/toolbar_action_view.h
index f5aad22b7cce8b80b8a2166fca20c315955dc6f0..80f1b91f6f2393b17f79ac0aad2addda4a5b0730 100644
--- a/chrome/browser/ui/views/toolbar/toolbar_action_view.h
+++ b/chrome/browser/ui/views/toolbar/toolbar_action_view.h
@@ -74,13 +74,13 @@ class ToolbarActionView : public views::MenuButton,
// an action wants to run.
static void DecorateWantsToRunBorder(views::LabelButtonBorder* border);
- // Overridden from views::View:
+ // views::View:
Peter Kasting 2015/01/24 02:20:59 Nit: This should say "views::MenuButton:"
oshima 2015/01/26 19:48:18 Done.
void GetAccessibleState(ui::AXViewState* state) override;
- // Overridden from views::ButtonListener:
+ // views::ButtonListener:
void ButtonPressed(views::Button* sender, const ui::Event& event) override;
- // Overridden from content::NotificationObserver:
+ // content::NotificationObserver:
void Observe(int type,
const content::NotificationSource& source,
const content::NotificationDetails& details) override;
@@ -113,11 +113,12 @@ class ToolbarActionView : public views::MenuButton,
bool wants_to_run_for_testing() const { return wants_to_run_; }
private:
- // Overridden from views::View:
+ // views::MenuButton:
+ gfx::Size GetPreferredSize() const override;
+ const char* GetClassName() const override;
+ void OnDragDone() override;
void ViewHierarchyChanged(
const ViewHierarchyChangedDetails& details) override;
- void OnDragDone() override;
- gfx::Size GetPreferredSize() const override;
void PaintChildren(gfx::Canvas* canvas,
const views::CullSet& cull_set) override;
void OnPaintBorder(gfx::Canvas* canvas) override;

Powered by Google App Engine
This is Rietveld 408576698