Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1166)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/views/login_view.h

Issue 869453002: Define class names for views class in c/b/ui/views (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: addressed comments Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/ui/views/find_bar_view.h ('K') | « chrome/browser/ui/views/location_bar/selected_keyword_view.cc ('k') | chrome/browser/ui/views/login_view.cc » ('j') | chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/login_view.h
diff --git a/chrome/browser/ui/views/login_view.h b/chrome/browser/ui/views/login_view.h
index f1bc90978352eba7d242e0ce49903bc01c068698..acbbf38749f8aa557fac55d868455485d5502574 100644
--- a/chrome/browser/ui/views/login_view.h
+++ b/chrome/browser/ui/views/login_view.h
@@ -29,7 +29,7 @@ class LoginView : public views::View,
const base::string16& GetUsername() const;
const base::string16& GetPassword() const;
- // LoginModelObserver implementation.
+ // LoginModelObserver:
Peter Kasting 2015/01/24 02:20:59 Nit: Prepend "password_manager::"
oshima 2015/01/26 19:48:18 Done.
void OnAutofillDataAvailable(const base::string16& username,
const base::string16& password) override;
void OnLoginModelDestroying() override;
@@ -38,6 +38,9 @@ class LoginView : public views::View,
views::View* GetInitiallyFocusedView();
private:
+ // views::View:
+ const char* GetClassName() const override;
+
// Non-owning refs to the input text fields.
views::Textfield* username_field_;
views::Textfield* password_field_;
« chrome/browser/ui/views/find_bar_view.h ('K') | « chrome/browser/ui/views/location_bar/selected_keyword_view.cc ('k') | chrome/browser/ui/views/login_view.cc » ('j') | chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698