chrome/browser/ui/views/toolbar/home_button.h - Issue 869453002: Define class names for views class in c/b/ui/views

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/toolbar/home_button.h

Issue 869453002: Define class names for views class in c/b/ui/views (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: inline class name strings Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/toolbar/home_button.h

diff --git a/chrome/browser/ui/views/toolbar/home_button.h b/chrome/browser/ui/views/toolbar/home_button.h

index 05fd0fdbe7c0765187cd473297ea06c47a23fa1f..27ba43084848de30581003768290f9d98f7cd078 100644

--- a/chrome/browser/ui/views/toolbar/home_button.h

+++ b/chrome/browser/ui/views/toolbar/home_button.h

@@ -25,6 +25,9 @@ class HomeButton : public ToolbarButton {

int OnPerformDrop(const ui::DropTargetEvent& event) override;

private:

+ // views::View:

Peter Kasting 2015/01/23 07:28:11 Nit: Again, this should be "ToolbarButton:".

oshima 2015/01/24 01:23:07 Done. moved all to private.

+ const char* GetClassName() const override;

// ToolbarButton:

void NotifyClick(const ui::Event& event) override;