Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Unified Diff: chrome/browser/ui/views/tab_icon_view.h

Issue 869453002: Define class names for views class in c/b/ui/views (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: inline class name strings Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/tab_icon_view.h
diff --git a/chrome/browser/ui/views/tab_icon_view.h b/chrome/browser/ui/views/tab_icon_view.h
index f3b2da2a283166a3de476d289d4484bce13371af..39ab92e2115112b3070f83de18a51b7e8080ac68 100644
--- a/chrome/browser/ui/views/tab_icon_view.h
+++ b/chrome/browser/ui/views/tab_icon_view.h
@@ -33,8 +33,9 @@ class TabIconView : public views::MenuButton {
// Set the throbber to the light style (for use on dark backgrounds).
void set_is_light(bool is_light) { is_light_ = is_light; }
- // Overridden from View
+ // views::View:
Peter Kasting 2015/01/23 07:28:10 Nit: This should refer to view::MenuButton instead
oshima 2015/01/24 01:23:07 Done. reordered & made them private.
void OnPaint(gfx::Canvas* canvas) override;
+ const char* GetClassName() const override;
gfx::Size GetPreferredSize() const override;
private:

Powered by Google App Engine
This is Rietveld 408576698