chrome/browser/ui/views/location_bar/page_action_with_badge_view.cc - Issue 869453002: Define class names for views class in c/b/ui/views

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/page_action_with_badge_view.cc

Issue 869453002: Define class names for views class in c/b/ui/views (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: inline class name strings Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/location_bar/keyword_hint_view.cc ('K') | « chrome/browser/ui/views/location_bar/page_action_with_badge_view.h ('k') | chrome/browser/ui/views/location_bar/selected_keyword_view.h » ('j') | chrome/browser/ui/views/location_bar/selected_keyword_view.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/location_bar/page_action_with_badge_view.cc

diff --git a/chrome/browser/ui/views/location_bar/page_action_with_badge_view.cc b/chrome/browser/ui/views/location_bar/page_action_with_badge_view.cc

index 8401dc2e16af0a77a5fa8e47c8f7a1482fc86e3c..5c36ecfa9380f324b479d7f9fb09e123eca7769d 100644

--- a/chrome/browser/ui/views/location_bar/page_action_with_badge_view.cc

+++ b/chrome/browser/ui/views/location_bar/page_action_with_badge_view.cc

@@ -18,6 +18,11 @@ void PageActionWithBadgeView::GetAccessibleState(

state->role = ui::AX_ROLE_GROUP;

}

+const char* PageActionWithBadgeView::GetClassName() const {

+ return "PageActionWithBadgeView";

gfx::Size PageActionWithBadgeView::GetPreferredSize() const {

return gfx::Size(ExtensionAction::kPageActionIconMaxSize,

ExtensionAction::kPageActionIconMaxSize);