Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(796)

Issue 869443003: Don't require -DSK_USE_POSIX_THREADS. (Closed)

Created:
5 years, 11 months ago by mtklein_C
Modified:
5 years, 11 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Don't require -DSK_USE_POSIX_THREADS. To compile SkCondVar, we already require either pthreads or Windows. This simplifies that code to not need SK_USE_POSIX_THREADS to be explicitly defined. We'll just look to see if we're targeting Windows, and if not, assume pthreads. Both before and after this CL, that code will fail to compile if we're not on Windows and don't have pthreads. BUG=skia: Committed: https://skia.googlesource.com/skia/+/4daa6f613cb7d8a3c07369af3e919ea65405ec55

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -51 lines) Patch
M gyp/common_conditions.gypi View 1 chunk +0 lines, -8 lines 0 comments Download
M src/core/SkPixelRef.cpp View 2 chunks +7 lines, -8 lines 0 comments Download
M src/utils/SkCondVar.h View 2 chunks +6 lines, -8 lines 0 comments Download
M src/utils/SkCondVar.cpp View 2 chunks +25 lines, -27 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mtklein
5 years, 11 months ago (2015-01-22 03:22:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/869443003/1
5 years, 11 months ago (2015-01-22 03:23:16 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 11 months ago (2015-01-22 03:23:17 UTC) #5
bungeman-skia
I think SK_USE_POSIX_THREADS used to be used to select things like mutex and thread implementations, ...
5 years, 11 months ago (2015-01-22 03:49:24 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-22 03:51:32 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/4daa6f613cb7d8a3c07369af3e919ea65405ec55

Powered by Google App Engine
This is Rietveld 408576698