Issue 8694007: Ensure that exception message is printed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8694007: Ensure that exception message is printed. (Closed)

Created:
9 years ago by sra1

Modified:
9 years ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Ensure that exception message is printed. This change improves the user experience for JS exceptions that pass through a Dart try-catch by making the Dart exception's toString() appear in the output. There is one missing piece: all toplevel code needs to be wrapped in a try-catch that calls $toDartException. Otherwise users will continue to see JS exceptions at the command-line. BUG= TEST=

Patch Set 1 #

Patch Set 2 : x #

Total comments: 2

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+61 lines, -29 lines)			Patch
	M	frog/corejs.dart	View	1	1 chunk	+30 lines, -14 lines	2 comments	Download
	M	frog/frogsh	View	1	2 chunks	+31 lines, -15 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

9 years ago (2011-11-29 00:46:18 UTC) #2

lgtm

http://codereview.chromium.org/8694007/diff/2001/frog/corejs.dart
File frog/corejs.dart (right):

http://codereview.chromium.org/8694007/diff/2001/frog/corejs.dart#newcode263
frog/corejs.dart:263: try {  // toString is in a try-catch due to Issue 470.
Issue 470 is fixed--can you see if the try-catch can be removed?

http://codereview.chromium.org/8694007/diff/2001/frog/corejs.dart#newcode297
frog/corejs.dart:297: // sra: Yes.
Can you add context about what conditions it happens? e.g.
// This happens with operators that aren't found because noSuchMethod fallbacks
are not correctly generated

(I think that's the only condition this should happen, but maybe you hit a
different one)

Expand Messages | Collapse Messages