Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Side by Side Diff: net/ssl/ssl_socket_config_service.h

Issue 869393005: Perform ClientHello padding if the field trial is enabled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@net_connection_error_uma
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef NET_SSL_SSL_SOCKET_CONFIG_SERVICE_H_
6 #define NET_SSL_SSL_SOCKET_CONFIG_SERVICE_H_
7
8 #include "base/macros.h"
9 #include "net/base/net_export.h"
10
11 namespace net {
12
13 class HostPortPair;
14
15 class NET_EXPORT SSLSocketConfigService {
16 public:
17 SSLSocketConfigService() : enabled_(false) {}
18 virtual ~SSLSocketConfigService() {}
19
20 // Enables fast radio padding.
21 void EnableFastRadioPadding();
22 // Disables fast radio padding.
23 void DisableFastRadioPadding();
Ryan Sleevi 2015/01/30 22:11:32 Why isn't this a single function with a bool arg?
24
25 // Checks to see whether the socket should be configured to use ClientHello
26 // padding.
27 bool UseFastRadioPadding(const HostPortPair& host_and_port);
28
29 // Returns whether this is a Google host/port or not. Matches host/port
30 // logic in ssl_client_socket_pool.cc
Ryan Sleevi 2015/01/30 22:11:32 This comment seems very much a layering violation.
31 virtual bool IsGoogle(const HostPortPair& host_and_port);
Ryan Sleevi 2015/01/30 22:11:32 Why is this virtual? "For Testing"?
32
33 private:
34 bool enabled_;
35
36 DISALLOW_COPY_AND_ASSIGN(SSLSocketConfigService);
37 };
38
39 } // namespace net
40
41 #endif // NET_SSL_SSL_SOCKET_CONFIG_SERVICE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698