Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(738)

Issue 869343004: Remove use of mojo.SurfacesService interface in html_viewer (Closed)

Created:
5 years, 10 months ago by jamesr
Modified:
5 years, 10 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, cc-bugs_chromium.org, ben+mojo_chromium.org, darin (slow to review)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove use of mojo.SurfacesService interface in html_viewer I'm planning to remove this interface in favor of connecting directly to mojo.Surface in the mojo repo, this updates html_viewer so it will still work after the removal. Committed: https://crrev.com/7971a8963de8fa6db33d5f0c9dab91f41b61b9bd Cr-Commit-Position: refs/heads/master@{#313858}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -33 lines) Patch
M mojo/cc/output_surface_mojo.h View 1 chunk +1 line, -2 lines 0 comments Download
M mojo/cc/output_surface_mojo.cc View 3 chunks +12 lines, -6 lines 0 comments Download
M mojo/services/html_viewer/html_document.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/services/html_viewer/weblayertreeview_impl.h View 2 chunks +1 line, -5 lines 0 comments Download
M mojo/services/html_viewer/weblayertreeview_impl.cc View 3 chunks +9 lines, -17 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jamesr
5 years, 10 months ago (2015-01-30 01:28:49 UTC) #2
Ken Rockot(use gerrit already)
lgtm
5 years, 10 months ago (2015-01-30 01:48:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/869343004/1
5 years, 10 months ago (2015-01-30 02:14:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-30 02:18:23 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 02:19:25 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7971a8963de8fa6db33d5f0c9dab91f41b61b9bd
Cr-Commit-Position: refs/heads/master@{#313858}

Powered by Google App Engine
This is Rietveld 408576698