Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Unified Diff: pkg/analysis_server/test/integration/asynchrony_test.dart

Issue 869343002: Fix the build by disabling asynchrony_test. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/integration/asynchrony_test.dart
diff --git a/pkg/analysis_server/test/integration/asynchrony_test.dart b/pkg/analysis_server/test/integration/asynchrony_test.dart
index ad4cd07b673bad2dddd23475c8dceb97a02eedcc..238b586344c3d04d71a4e9fb08a9f6a87832f8c8 100644
--- a/pkg/analysis_server/test/integration/asynchrony_test.dart
+++ b/pkg/analysis_server/test/integration/asynchrony_test.dart
@@ -12,7 +12,7 @@ import '../reflective_tests.dart';
import 'integration_tests.dart';
main() {
- runReflectiveTests(AsynchronyIntegrationTest);
+// runReflectiveTests(AsynchronyIntegrationTest);
}
/**
@@ -23,6 +23,12 @@ main() {
*
* Once enough commands have been sent, we begin reading from the server's
* output buffer, and verify that it responds to the last command.
+ *
+ * NB.
+ *
+ * This test was intentionally disabled, because after r43123 server
+ * writes to stdout synchronously. So, now it is the client's responsibility
+ * to read stdout in a timely manner to avoid blocking the server.
*/
@reflectiveTest
class AsynchronyIntegrationTest {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698