Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1071)

Unified Diff: Source/core/rendering/RenderMenuList.h

Issue 869323003: Oilpan: move RenderObjects off heap. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: review-induced improvements Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/rendering/RenderMedia.cpp ('k') | Source/core/rendering/RenderMenuList.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/RenderMenuList.h
diff --git a/Source/core/rendering/RenderMenuList.h b/Source/core/rendering/RenderMenuList.h
index 3660c6cb88bcf39063806b950842a88049f94e86..f347870b4dbb45d8c1a66c2da5979dd5ddd88d63 100644
--- a/Source/core/rendering/RenderMenuList.h
+++ b/Source/core/rendering/RenderMenuList.h
@@ -37,10 +37,9 @@ class RenderText;
class RenderMenuList final : public RenderFlexibleBox, private PopupMenuClient {
public:
- RenderMenuList(Element*);
+ explicit RenderMenuList(Element*);
virtual ~RenderMenuList();
virtual void destroy() override;
- virtual void trace(Visitor*) override;
bool popupIsVisible() const { return m_popupIsVisible; }
void showPopup();
@@ -119,8 +118,8 @@ private:
void didUpdateActiveOption(int optionIndex);
- RawPtrWillBeMember<RenderText> m_buttonText;
- RawPtrWillBeMember<RenderBlock> m_innerBlock;
+ RenderText* m_buttonText;
+ RenderBlock* m_innerBlock;
bool m_optionsChanged;
int m_optionsWidth;
@@ -129,7 +128,7 @@ private:
RefPtr<RenderStyle> m_optionStyle;
- RefPtrWillBeMember<PopupMenu> m_popup;
+ RefPtrWillBePersistent<PopupMenu> m_popup;
bool m_popupIsVisible;
};
« no previous file with comments | « Source/core/rendering/RenderMedia.cpp ('k') | Source/core/rendering/RenderMenuList.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698