Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1313)

Unified Diff: Source/core/rendering/RenderGrid.cpp

Issue 869323003: Oilpan: move RenderObjects off heap. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: review-induced improvements Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/rendering/RenderFullScreen.cpp ('k') | Source/core/rendering/RenderInline.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/RenderGrid.cpp
diff --git a/Source/core/rendering/RenderGrid.cpp b/Source/core/rendering/RenderGrid.cpp
index 6a55e68cb75600676d80e5b4385a0b3ce4e19dd3..07451ab9878f5f4a62b554b0e3ef2095ebbbbafb 100644
--- a/Source/core/rendering/RenderGrid.cpp
+++ b/Source/core/rendering/RenderGrid.cpp
@@ -248,7 +248,7 @@ public:
// Performance optimization: hold onto these Vectors until the end of Layout to avoid repeated malloc / free.
Vector<GridTrack*> filteredTracks;
- WillBeHeapVector<GridItemWithSpan> itemsSortedByIncreasingSpan;
+ Vector<GridItemWithSpan> itemsSortedByIncreasingSpan;
Vector<GridTrack*> growBeyondGrowthLimitsTracks;
};
@@ -666,10 +666,9 @@ LayoutUnit RenderGrid::maxContentForChild(RenderBox& child, GridTrackSizingDirec
// std::pair<RenderBox*, size_t> does not work either because we still need the GridCoordinate so we'd have to add an
// extra hash lookup for each item at the beginning of RenderGrid::resolveContentBasedTrackSizingFunctionsForItems().
class GridItemWithSpan {
- ALLOW_ONLY_INLINE_ALLOCATION();
public:
GridItemWithSpan(RenderBox& gridItem, const GridCoordinate& coordinate, GridTrackSizingDirection direction)
- : m_gridItem(gridItem)
+ : m_gridItem(&gridItem)
, m_coordinate(coordinate)
{
const GridSpan& span = (direction == ForRows) ? coordinate.rows : coordinate.columns;
@@ -684,13 +683,8 @@ public:
bool operator<(const GridItemWithSpan other) const { return m_span < other.m_span; }
- void trace(Visitor* visitor)
- {
- visitor->trace(m_gridItem);
- }
-
private:
- RawPtrWillBeMember<RenderBox> m_gridItem;
+ RenderBox* m_gridItem;
GridCoordinate m_coordinate;
size_t m_span;
};
« no previous file with comments | « Source/core/rendering/RenderFullScreen.cpp ('k') | Source/core/rendering/RenderInline.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698