Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Unified Diff: Source/core/animation/CompositorAnimationsTest.cpp

Issue 869323003: Oilpan: move RenderObjects off heap. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: review-induced improvements Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/dom/FirstLetterPseudoElement.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/animation/CompositorAnimationsTest.cpp
diff --git a/Source/core/animation/CompositorAnimationsTest.cpp b/Source/core/animation/CompositorAnimationsTest.cpp
index 4cc6e91e1464e049dc9b4f36e09b1587557454c2..e07d979c500e827982105c886d4fdd15d696acdf 100644
--- a/Source/core/animation/CompositorAnimationsTest.cpp
+++ b/Source/core/animation/CompositorAnimationsTest.cpp
@@ -256,18 +256,19 @@ public:
class RenderObjectProxy : public RenderObject {
public:
- static PassOwnPtrWillBeRawPtr<RenderObjectProxy> create(Node* node)
+ static RenderObjectProxy* create(Node* node)
{
- return adoptPtrWillBeNoop(new RenderObjectProxy(node));
+ return new RenderObjectProxy(node);
}
- static void dispose(PassOwnPtrWillBeRawPtr<RenderObjectProxy> object)
+ static void dispose(RenderObjectProxy* proxy)
{
- object.leakPtr()->destroy();
+ proxy->destroy();
}
const char* renderName() const override { return nullptr; }
void layout() override { }
+
private:
explicit RenderObjectProxy(Node* node)
: RenderObject(node)
@@ -1202,8 +1203,8 @@ TEST_F(AnimationCompositorAnimationsTest, CancelIncompatibleCompositorAnimations
RefPtrWillBePersistent<Element> element = m_document->createElement("shared", ASSERT_NO_EXCEPTION);
- OwnPtrWillBePersistent<RenderObjectProxy> renderer = RenderObjectProxy::create(element.get());
- element->setRenderer(renderer.get());
+ RenderObjectProxy* renderer = RenderObjectProxy::create(element.get());
+ element->setRenderer(renderer);
AnimatableValueKeyframeVector keyFrames;
keyFrames.append(createDefaultKeyframe(CSSPropertyOpacity, AnimationEffect::CompositeReplace, 0.0).get());
@@ -1242,7 +1243,7 @@ TEST_F(AnimationCompositorAnimationsTest, CancelIncompatibleCompositorAnimations
simulateFrame(1.);
element->setRenderer(nullptr);
- RenderObjectProxy::dispose(renderer.release());
+ RenderObjectProxy::dispose(renderer);
player1.release();
player2.release();
« no previous file with comments | « no previous file | Source/core/dom/FirstLetterPseudoElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698