Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Unified Diff: Source/core/rendering/RenderTextFragment.h

Issue 869323003: Oilpan: move RenderObjects off heap. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: minor fixes Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/RenderTextFragment.h
diff --git a/Source/core/rendering/RenderTextFragment.h b/Source/core/rendering/RenderTextFragment.h
index 3cd396faacd45d8ad271db6a8c4040cab3c4aa2e..cd2bb0543e38c8a8731c04abd976765b9e455d77 100644
--- a/Source/core/rendering/RenderTextFragment.h
+++ b/Source/core/rendering/RenderTextFragment.h
@@ -38,7 +38,6 @@ public:
RenderTextFragment(Node*, StringImpl*, int startOffset, int length);
RenderTextFragment(Node*, StringImpl*);
virtual ~RenderTextFragment();
- virtual void trace(Visitor*) override;
virtual void destroy() override;
virtual bool isTextFragment() const override { return true; }
@@ -83,7 +82,8 @@ private:
unsigned m_end;
bool m_isRemainingTextRenderer;
RefPtr<StringImpl> m_contentString;
- RawPtrWillBeMember<FirstLetterPseudoElement> m_firstLetterPseudoElement;
+ // Oilpan: weak reference back to GCed owner; its lifetime subsumes this object.
haraken 2015/02/04 05:48:56 I'm not sure of this comment. Even if RenderObject
sof 2015/02/04 08:44:32 It was a Member<> when RenderObject was on heap, a
+ FirstLetterPseudoElement* m_firstLetterPseudoElement;
};
DEFINE_TYPE_CASTS(RenderTextFragment, RenderObject, object, toRenderText(object)->isTextFragment(), toRenderText(object).isTextFragment());

Powered by Google App Engine
This is Rietveld 408576698