Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Side by Side Diff: Source/core/rendering/svg/RenderSVGResourceLinearGradient.h

Issue 869323003: Oilpan: move RenderObjects off heap. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: review-induced improvements Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2006 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) Research In Motion Limited 2010. All rights reserved. 3 * Copyright (C) Research In Motion Limited 2010. All rights reserved.
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 20 matching lines...) Expand all
31 class RenderSVGResourceLinearGradient final : public RenderSVGResourceGradient { 31 class RenderSVGResourceLinearGradient final : public RenderSVGResourceGradient {
32 public: 32 public:
33 explicit RenderSVGResourceLinearGradient(SVGLinearGradientElement*); 33 explicit RenderSVGResourceLinearGradient(SVGLinearGradientElement*);
34 virtual ~RenderSVGResourceLinearGradient(); 34 virtual ~RenderSVGResourceLinearGradient();
35 35
36 virtual const char* renderName() const override { return "RenderSVGResourceL inearGradient"; } 36 virtual const char* renderName() const override { return "RenderSVGResourceL inearGradient"; }
37 37
38 static const RenderSVGResourceType s_resourceType = LinearGradientResourceTy pe; 38 static const RenderSVGResourceType s_resourceType = LinearGradientResourceTy pe;
39 virtual RenderSVGResourceType resourceType() const override { return s_resou rceType; } 39 virtual RenderSVGResourceType resourceType() const override { return s_resou rceType; }
40 40
41 virtual SVGUnitTypes::SVGUnitType gradientUnits() const override { return m_ attributes.gradientUnits(); } 41 virtual SVGUnitTypes::SVGUnitType gradientUnits() const override { return at tributes().gradientUnits(); }
42 virtual void calculateGradientTransform(AffineTransform& transform) override { transform = m_attributes.gradientTransform(); } 42 virtual void calculateGradientTransform(AffineTransform& transform) override { transform = attributes().gradientTransform(); }
43 virtual bool collectGradientAttributes(SVGGradientElement*) override; 43 virtual bool collectGradientAttributes(SVGGradientElement*) override;
44 virtual void buildGradient(GradientData*) const override; 44 virtual void buildGradient(GradientData*) const override;
45 45
46 FloatPoint startPoint(const LinearGradientAttributes&) const; 46 FloatPoint startPoint(const LinearGradientAttributes&) const;
47 FloatPoint endPoint(const LinearGradientAttributes&) const; 47 FloatPoint endPoint(const LinearGradientAttributes&) const;
48 48
49 virtual void trace(Visitor*) override; 49 private:
50 #if ENABLE(OILPAN)
51 // FIXME: Oilpan: the RenderObject hierarchy isn't on the heap, but
52 // the SVG property hierarchy is. And the two meet here, so keep a
53 // persistent reference to the SVG part object by way of a heap-allocated
54 // wrapper object.
55 Persistent<LinearGradientAttributesWrapper> m_attributesWrapper;
50 56
51 private: 57 LinearGradientAttributes& mutableAttributes() { return m_attributesWrapper-> attributes(); }
58 const LinearGradientAttributes& attributes() const { return m_attributesWrap per->attributes(); }
59 #else
52 LinearGradientAttributes m_attributes; 60 LinearGradientAttributes m_attributes;
61
62 LinearGradientAttributes& mutableAttributes() { return m_attributes; }
63 const LinearGradientAttributes& attributes() const { return m_attributes; }
64 #endif
53 }; 65 };
54 66
55 } // namespace blink 67 } // namespace blink
56 68
57 #endif // RenderSVGResourceLinearGradient_h 69 #endif // RenderSVGResourceLinearGradient_h
OLDNEW
« no previous file with comments | « Source/core/rendering/svg/RenderSVGResourceFilter.cpp ('k') | Source/core/rendering/svg/RenderSVGResourceLinearGradient.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698