Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1172)

Side by Side Diff: Source/core/rendering/RenderObjectChildList.h

Issue 869323003: Oilpan: move RenderObjects off heap. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: review-induced improvements Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/rendering/RenderObject.cpp ('k') | Source/core/rendering/RenderObjectChildList.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Apple Inc. All rights reserved. 2 * Copyright (C) 2009 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 23 matching lines...) Expand all
34 class RenderObject; 34 class RenderObject;
35 35
36 class RenderObjectChildList { 36 class RenderObjectChildList {
37 DISALLOW_ALLOCATION(); 37 DISALLOW_ALLOCATION();
38 public: 38 public:
39 RenderObjectChildList() 39 RenderObjectChildList()
40 : m_firstChild(nullptr) 40 : m_firstChild(nullptr)
41 , m_lastChild(nullptr) 41 , m_lastChild(nullptr)
42 { 42 {
43 } 43 }
44 void trace(Visitor*);
45 44
46 RenderObject* firstChild() const { return m_firstChild.get(); } 45 RenderObject* firstChild() const { return m_firstChild; }
47 RenderObject* lastChild() const { return m_lastChild.get(); } 46 RenderObject* lastChild() const { return m_lastChild; }
48 47
49 // FIXME: Temporary while RenderBox still exists. Eventually this will just happen during insert/append/remove methods on the child list, and nobody 48 // FIXME: Temporary while RenderBox still exists. Eventually this will just happen during insert/append/remove methods on the child list, and nobody
50 // will need to manipulate firstChild or lastChild directly. 49 // will need to manipulate firstChild or lastChild directly.
51 void setFirstChild(RenderObject* child) { m_firstChild = child; } 50 void setFirstChild(RenderObject* child) { m_firstChild = child; }
52 void setLastChild(RenderObject* child) { m_lastChild = child; } 51 void setLastChild(RenderObject* child) { m_lastChild = child; }
53 52
54 void destroyLeftoverChildren(); 53 void destroyLeftoverChildren();
55 54
56 RenderObject* removeChildNode(RenderObject* owner, RenderObject*, bool notif yRenderer = true); 55 RenderObject* removeChildNode(RenderObject* owner, RenderObject*, bool notif yRenderer = true);
57 void insertChildNode(RenderObject* owner, RenderObject* newChild, RenderObje ct* beforeChild, bool notifyRenderer = true); 56 void insertChildNode(RenderObject* owner, RenderObject* newChild, RenderObje ct* beforeChild, bool notifyRenderer = true);
58 void appendChildNode(RenderObject* owner, RenderObject* newChild, bool notif yRenderer = true) 57 void appendChildNode(RenderObject* owner, RenderObject* newChild, bool notif yRenderer = true)
59 { 58 {
60 insertChildNode(owner, newChild, 0, notifyRenderer); 59 insertChildNode(owner, newChild, 0, notifyRenderer);
61 } 60 }
62 61
63 private: 62 private:
64 void invalidatePaintOnRemoval(const RenderObject& oldChild); 63 void invalidatePaintOnRemoval(const RenderObject& oldChild);
65 64
66 RawPtrWillBeMember<RenderObject> m_firstChild; 65 RenderObject* m_firstChild;
67 RawPtrWillBeMember<RenderObject> m_lastChild; 66 RenderObject* m_lastChild;
68 }; 67 };
69 68
70 } // namespace blink 69 } // namespace blink
71 70
72 #endif // RenderObjectChildList_h 71 #endif // RenderObjectChildList_h
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderObject.cpp ('k') | Source/core/rendering/RenderObjectChildList.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698