Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Side by Side Diff: Source/core/rendering/RenderListItem.cpp

Issue 869323003: Oilpan: move RenderObjects off heap. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: review-induced improvements Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/rendering/RenderListItem.h ('k') | Source/core/rendering/RenderListMarker.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /** 1 /**
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2003, 2004, 2005, 2006, 2010 Apple Inc. All rights reserved. 4 * Copyright (C) 2003, 2004, 2005, 2006, 2010 Apple Inc. All rights reserved.
5 * Copyright (C) 2006 Andrew Wellington (proton@wiretapped.net) 5 * Copyright (C) 2006 Andrew Wellington (proton@wiretapped.net)
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 29 matching lines...) Expand all
40 RenderListItem::RenderListItem(Element* element) 40 RenderListItem::RenderListItem(Element* element)
41 : RenderBlockFlow(element) 41 : RenderBlockFlow(element)
42 , m_marker(nullptr) 42 , m_marker(nullptr)
43 , m_hasExplicitValue(false) 43 , m_hasExplicitValue(false)
44 , m_isValueUpToDate(false) 44 , m_isValueUpToDate(false)
45 , m_notInList(false) 45 , m_notInList(false)
46 { 46 {
47 setInline(false); 47 setInline(false);
48 } 48 }
49 49
50 void RenderListItem::trace(Visitor* visitor)
51 {
52 visitor->trace(m_marker);
53 RenderBlockFlow::trace(visitor);
54 }
55
56 void RenderListItem::styleDidChange(StyleDifference diff, const RenderStyle* old Style) 50 void RenderListItem::styleDidChange(StyleDifference diff, const RenderStyle* old Style)
57 { 51 {
58 RenderBlockFlow::styleDidChange(diff, oldStyle); 52 RenderBlockFlow::styleDidChange(diff, oldStyle);
59 53
60 if (style()->listStyleType() != NoneListStyle 54 if (style()->listStyleType() != NoneListStyle
61 || (style()->listStyleImage() && !style()->listStyleImage()->errorOccurr ed())) { 55 || (style()->listStyleImage() && !style()->listStyleImage()->errorOccurr ed())) {
62 if (!m_marker) 56 if (!m_marker)
63 m_marker = RenderListMarker::createAnonymous(this); 57 m_marker = RenderListMarker::createAnonymous(this);
64 m_marker->listItemStyleDidChange(); 58 m_marker->listItemStyleDidChange();
65 } else if (m_marker) { 59 } else if (m_marker) {
(...skipping 454 matching lines...) Expand 10 before | Expand all | Expand 10 after
520 // assume that all the following ones have too. 514 // assume that all the following ones have too.
521 // This gives us the opportunity to stop here and avoid 515 // This gives us the opportunity to stop here and avoid
522 // marking the same nodes again. 516 // marking the same nodes again.
523 break; 517 break;
524 } 518 }
525 item->updateValue(); 519 item->updateValue();
526 } 520 }
527 } 521 }
528 522
529 } // namespace blink 523 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderListItem.h ('k') | Source/core/rendering/RenderListMarker.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698