Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Side by Side Diff: Source/core/rendering/RenderFullScreen.cpp

Issue 869323003: Oilpan: move RenderObjects off heap. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: review-induced improvements Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/rendering/RenderFullScreen.h ('k') | Source/core/rendering/RenderGrid.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2010 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
63 setReplaced(false); 63 setReplaced(false);
64 } 64 }
65 65
66 RenderFullScreen* RenderFullScreen::createAnonymous(Document* document) 66 RenderFullScreen* RenderFullScreen::createAnonymous(Document* document)
67 { 67 {
68 RenderFullScreen* renderer = new RenderFullScreen(); 68 RenderFullScreen* renderer = new RenderFullScreen();
69 renderer->setDocumentForAnonymous(document); 69 renderer->setDocumentForAnonymous(document);
70 return renderer; 70 return renderer;
71 } 71 }
72 72
73 void RenderFullScreen::trace(Visitor* visitor)
74 {
75 visitor->trace(m_placeholder);
76 RenderFlexibleBox::trace(visitor);
77 }
78
79 void RenderFullScreen::willBeDestroyed() 73 void RenderFullScreen::willBeDestroyed()
80 { 74 {
81 if (m_placeholder) { 75 if (m_placeholder) {
82 remove(); 76 remove();
83 if (!m_placeholder->beingDestroyed()) 77 if (!m_placeholder->beingDestroyed())
84 m_placeholder->destroy(); 78 m_placeholder->destroy();
85 ASSERT(!m_placeholder); 79 ASSERT(!m_placeholder);
86 } 80 }
87 81
88 // RenderObjects are unretained, so notify the document (which holds a point er to a RenderFullScreen) 82 // RenderObjects are unretained, so notify the document (which holds a point er to a RenderFullScreen)
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
205 if (!m_placeholder) { 199 if (!m_placeholder) {
206 m_placeholder = new RenderFullScreenPlaceholder(this); 200 m_placeholder = new RenderFullScreenPlaceholder(this);
207 m_placeholder->setStyle(style); 201 m_placeholder->setStyle(style);
208 if (parent()) { 202 if (parent()) {
209 parent()->addChild(m_placeholder, this); 203 parent()->addChild(m_placeholder, this);
210 parent()->setNeedsLayoutAndPrefWidthsRecalcAndFullPaintInvalidation( ); 204 parent()->setNeedsLayoutAndPrefWidthsRecalcAndFullPaintInvalidation( );
211 } 205 }
212 } else 206 } else
213 m_placeholder->setStyle(style); 207 m_placeholder->setStyle(style);
214 } 208 }
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderFullScreen.h ('k') | Source/core/rendering/RenderGrid.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698