Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Side by Side Diff: Source/core/layout/LayoutTableRowTest.cpp

Issue 869323003: Oilpan: move RenderObjects off heap. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: review-induced improvements Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/layout/LayoutTableRow.cpp ('k') | Source/core/layout/LayoutTableSection.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 m_pageHolder = DummyPageHolder::create(IntSize(800, 600)); 44 m_pageHolder = DummyPageHolder::create(IntSize(800, 600));
45 m_row = LayoutTableRow::createAnonymous(&m_pageHolder->document()); 45 m_row = LayoutTableRow::createAnonymous(&m_pageHolder->document());
46 } 46 }
47 47
48 virtual void TearDown() 48 virtual void TearDown()
49 { 49 {
50 m_row->destroy(); 50 m_row->destroy();
51 } 51 }
52 52
53 OwnPtr<DummyPageHolder> m_pageHolder; 53 OwnPtr<DummyPageHolder> m_pageHolder;
54 RawPtrWillBePersistent<LayoutTableRow> m_row; 54 LayoutTableRow* m_row;
55 }; 55 };
56 56
57 TEST_F(LayoutTableRowDeathTest, CanSetRow) 57 TEST_F(LayoutTableRowDeathTest, CanSetRow)
58 { 58 {
59 static const unsigned rowIndex = 10; 59 static const unsigned rowIndex = 10;
60 m_row->setRowIndex(rowIndex); 60 m_row->setRowIndex(rowIndex);
61 EXPECT_EQ(rowIndex, m_row->rowIndex()); 61 EXPECT_EQ(rowIndex, m_row->rowIndex());
62 } 62 }
63 63
64 TEST_F(LayoutTableRowDeathTest, CanSetRowToMaxRowIndex) 64 TEST_F(LayoutTableRowDeathTest, CanSetRowToMaxRowIndex)
(...skipping 14 matching lines...) Expand all
79 TEST_F(LayoutTableRowDeathTest, CrashIfSettingUnsetRowIndex) 79 TEST_F(LayoutTableRowDeathTest, CrashIfSettingUnsetRowIndex)
80 { 80 {
81 ASSERT_DEATH(m_row->setRowIndex(unsetRowIndex), ""); 81 ASSERT_DEATH(m_row->setRowIndex(unsetRowIndex), "");
82 } 82 }
83 83
84 #endif 84 #endif
85 85
86 } 86 }
87 87
88 } // namespace blink 88 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/layout/LayoutTableRow.cpp ('k') | Source/core/layout/LayoutTableSection.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698