Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1118)

Side by Side Diff: Source/core/layout/LayoutTableRow.cpp

Issue 869323003: Oilpan: move RenderObjects off heap. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: review-induced improvements Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/layout/LayoutTableRow.h ('k') | Source/core/layout/LayoutTableRowTest.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2013 Apple Inc. All rights reserved. 7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2013 Apple Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 29 matching lines...) Expand all
40 using namespace HTMLNames; 40 using namespace HTMLNames;
41 41
42 LayoutTableRow::LayoutTableRow(Element* element) 42 LayoutTableRow::LayoutTableRow(Element* element)
43 : RenderBox(element) 43 : RenderBox(element)
44 , m_rowIndex(unsetRowIndex) 44 , m_rowIndex(unsetRowIndex)
45 { 45 {
46 // init RenderObject attributes 46 // init RenderObject attributes
47 setInline(false); // our object is not Inline 47 setInline(false); // our object is not Inline
48 } 48 }
49 49
50 void LayoutTableRow::trace(Visitor* visitor)
51 {
52 visitor->trace(m_children);
53 RenderBox::trace(visitor);
54 }
55
56 void LayoutTableRow::willBeRemovedFromTree() 50 void LayoutTableRow::willBeRemovedFromTree()
57 { 51 {
58 RenderBox::willBeRemovedFromTree(); 52 RenderBox::willBeRemovedFromTree();
59 53
60 section()->setNeedsCellRecalc(); 54 section()->setNeedsCellRecalc();
61 } 55 }
62 56
63 static bool borderWidthChanged(const RenderStyle* oldStyle, const RenderStyle* n ewStyle) 57 static bool borderWidthChanged(const RenderStyle* oldStyle, const RenderStyle* n ewStyle)
64 { 58 {
65 return oldStyle->borderLeftWidth() != newStyle->borderLeftWidth() 59 return oldStyle->borderLeftWidth() != newStyle->borderLeftWidth()
(...skipping 191 matching lines...) Expand 10 before | Expand all | Expand 10 after
257 // The cell and the row share the section's coordinate system. However 251 // The cell and the row share the section's coordinate system. However
258 // the visual overflow should be determined in the coordinate system of 252 // the visual overflow should be determined in the coordinate system of
259 // the row, that's why we shift it below. 253 // the row, that's why we shift it below.
260 LayoutUnit cellOffsetLogicalTopDifference = cell->location().y() - location( ).y(); 254 LayoutUnit cellOffsetLogicalTopDifference = cell->location().y() - location( ).y();
261 cellVisualOverflowRect.move(0, cellOffsetLogicalTopDifference); 255 cellVisualOverflowRect.move(0, cellOffsetLogicalTopDifference);
262 256
263 addVisualOverflow(cellVisualOverflowRect); 257 addVisualOverflow(cellVisualOverflowRect);
264 } 258 }
265 259
266 } // namespace blink 260 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/layout/LayoutTableRow.h ('k') | Source/core/layout/LayoutTableRowTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698