Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Side by Side Diff: Source/core/frame/FrameView.h

Issue 869323003: Oilpan: move RenderObjects off heap. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: review-induced improvements Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/dom/NodeRareData.cpp ('k') | Source/core/frame/FrameView.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 (C) 1998 Waldo Bastian (bastian@kde.org) 3 (C) 1998 Waldo Bastian (bastian@kde.org)
4 (C) 1998, 1999 Torben Weis (weis@kde.org) 4 (C) 1998, 1999 Torben Weis (weis@kde.org)
5 (C) 1999 Lars Knoll (knoll@kde.org) 5 (C) 1999 Lars Knoll (knoll@kde.org)
6 (C) 1999 Antti Koivisto (koivisto@kde.org) 6 (C) 1999 Antti Koivisto (koivisto@kde.org)
7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed. 7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed.
8 8
9 This library is free software; you can redistribute it and/or 9 This library is free software; you can redistribute it and/or
10 modify it under the terms of the GNU Library General Public 10 modify it under the terms of the GNU Library General Public
(...skipping 681 matching lines...) Expand 10 before | Expand all | Expand 10 after
692 void updateOverhangAreas(); 692 void updateOverhangAreas();
693 693
694 bool isFrameViewScrollbar(const Widget* child) const { return horizontalScro llbar() == child || verticalScrollbar() == child; } 694 bool isFrameViewScrollbar(const Widget* child) const { return horizontalScro llbar() == child || verticalScrollbar() == child; }
695 695
696 ScrollingCoordinator* scrollingCoordinator(); 696 ScrollingCoordinator* scrollingCoordinator();
697 697
698 static double s_currentFrameTimeStamp; // used for detecting decoded resourc e thrash in the cache 698 static double s_currentFrameTimeStamp; // used for detecting decoded resourc e thrash in the cache
699 699
700 LayoutSize m_size; 700 LayoutSize m_size;
701 701
702 typedef WillBeHeapHashSet<RefPtrWillBeMember<RenderEmbeddedObject>> Embedded ObjectSet; 702 typedef HashSet<RefPtr<RenderEmbeddedObject>> EmbeddedObjectSet;
703 WillBeHeapHashSet<RefPtrWillBeMember<RenderEmbeddedObject>> m_partUpdateSet; 703 EmbeddedObjectSet m_partUpdateSet;
704 704
705 // FIXME: These are just "children" of the FrameView and should be RefPtrWil lBeMember<Widget> instead. 705 // FIXME: These are just "children" of the FrameView and should be RefPtrWil lBeMember<Widget> instead.
706 WillBeHeapHashSet<RefPtrWillBeMember<RenderPart>> m_parts; 706 HashSet<RefPtr<RenderPart>> m_parts;
707 707
708 // The RefPtr cycle between LocalFrame and FrameView is broken 708 // The RefPtr cycle between LocalFrame and FrameView is broken
709 // when a LocalFrame is detached by FrameLoader::detachFromParent(). 709 // when a LocalFrame is detached by FrameLoader::detachFromParent().
710 // It clears the LocalFrame's m_view reference via setView(nullptr). 710 // It clears the LocalFrame's m_view reference via setView(nullptr).
711 // 711 //
712 // For Oilpan, Member reference cycles pose no problem, but 712 // For Oilpan, Member reference cycles pose no problem, but
713 // LocalFrame's FrameView is also cleared by setView(). This additionally 713 // LocalFrame's FrameView is also cleared by setView(). This additionally
714 // triggers FrameView::dispose(), which performs the operations 714 // triggers FrameView::dispose(), which performs the operations
715 // that cannot be delayed until finalization time. 715 // that cannot be delayed until finalization time.
716 RefPtrWillBeMember<LocalFrame> m_frame; 716 RefPtrWillBeMember<LocalFrame> m_frame;
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
763 bool m_isPainting; 763 bool m_isPainting;
764 764
765 unsigned m_visuallyNonEmptyCharacterCount; 765 unsigned m_visuallyNonEmptyCharacterCount;
766 unsigned m_visuallyNonEmptyPixelCount; 766 unsigned m_visuallyNonEmptyPixelCount;
767 bool m_isVisuallyNonEmpty; 767 bool m_isVisuallyNonEmpty;
768 bool m_firstVisuallyNonEmptyLayoutCallbackPending; 768 bool m_firstVisuallyNonEmptyLayoutCallbackPending;
769 769
770 RefPtrWillBeMember<Node> m_maintainScrollPositionAnchor; 770 RefPtrWillBeMember<Node> m_maintainScrollPositionAnchor;
771 771
772 // Renderer to hold our custom scroll corner. 772 // Renderer to hold our custom scroll corner.
773 RawPtrWillBeMember<RenderScrollbarPart> m_scrollCorner; 773 RenderScrollbarPart* m_scrollCorner;
774 774
775 OwnPtr<ScrollableAreaSet> m_scrollableAreas; 775 OwnPtr<ScrollableAreaSet> m_scrollableAreas;
776 OwnPtr<ScrollableAreaSet> m_animatingScrollableAreas; 776 OwnPtr<ScrollableAreaSet> m_animatingScrollableAreas;
777 OwnPtr<ResizerAreaSet> m_resizerAreas; 777 OwnPtr<ResizerAreaSet> m_resizerAreas;
778 OwnPtr<ViewportConstrainedObjectSet> m_viewportConstrainedObjects; 778 OwnPtr<ViewportConstrainedObjectSet> m_viewportConstrainedObjects;
779 OwnPtrWillBeMember<FrameViewAutoSizeInfo> m_autoSizeInfo; 779 OwnPtrWillBeMember<FrameViewAutoSizeInfo> m_autoSizeInfo;
780 780
781 float m_visibleContentScaleFactor; 781 float m_visibleContentScaleFactor;
782 IntSize m_inputEventsOffsetForEmulation; 782 IntSize m_inputEventsOffsetForEmulation;
783 float m_inputEventsScaleFactorForEmulation; 783 float m_inputEventsScaleFactorForEmulation;
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
873 } 873 }
874 874
875 private: 875 private:
876 RawPtrWillBeMember<FrameView> m_view; 876 RawPtrWillBeMember<FrameView> m_view;
877 bool m_originalValue; 877 bool m_originalValue;
878 }; 878 };
879 879
880 } // namespace blink 880 } // namespace blink
881 881
882 #endif // FrameView_h 882 #endif // FrameView_h
OLDNEW
« no previous file with comments | « Source/core/dom/NodeRareData.cpp ('k') | Source/core/frame/FrameView.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698