Oilpan: move RenderObjects off heap.

Source/core/rendering/svg/RenderSVGResourcePattern.h

 /*
  * Copyright (C) 2006 Nikolas Zimmermann <zimmermann@kde.org>
  * Copyright (C) Research In Motion Limited 2010. All rights reserved.
  * Copyright 2014 The Chromium Authors. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
@@ skipping 34 matching lines @@
     virtual const char* renderName() const override { return "RenderSVGResourcePattern"; }
 
     virtual void removeAllClientsFromCache(bool markForInvalidation = true) override;
     virtual void removeClientFromCache(RenderObject*, bool markForInvalidation = true) override;
 
     virtual SVGPaintServer preparePaintServer(const RenderObject&) override;
 
     static const RenderSVGResourceType s_resourceType = PatternResourceType;
     virtual RenderSVGResourceType resourceType() const override { return s_resourceType; }
 
-    virtual void trace(Visitor*) override;
-
 private:
     PassOwnPtr<PatternData> buildPatternData(const RenderObject&);
     PassRefPtr<const SkPicture> asPicture(const FloatRect& tile, const AffineTransform&) const;
     PatternData* patternForRenderer(const RenderObject&);
 
     bool m_shouldCollectPatternAttributes : 1;
+#if ENABLE(OILPAN)
+    Persistent<PatternAttributesWrapper> m_attributesWrapper;

[haraken, 2015/02/04 05:48:56]

Can we avoid introducing a wrapper by making PatternAttributes not-a-part-of
object in both oilpan and non-oilpan builds?

[sof, 2015/02/04 08:44:32]

That would entail moving the value-based GradientAttributes hierarchy to the
heap and reworking the code that works over it to be imperative. Do we want to
do that & address that here?

[haraken, 2015/02/04 09:25:10]

I thought we can just use OwnPtrWillBePersistent<PatternAttributes> here, but
won't it work?

+
+    PatternAttributes& mutableAttributes() { return m_attributesWrapper->attributes(); }
+    const PatternAttributes& attributes() const { return m_attributesWrapper->attributes(); }
+#else
     PatternAttributes m_attributes;
 
+    PatternAttributes& mutableAttributes() { return m_attributes; }
+    const PatternAttributes& attributes() const { return m_attributes; }
+#endif
+
     // FIXME: we can almost do away with this per-object map, but not quite: the tile size can be
     // relative to the client bounding box, and it gets captured in the cached Pattern shader.
     // Hence, we need one Pattern shader per client. The display list OTOH is the same => we
     // should be able to cache a single display list per RenderSVGResourcePattern + one
     // Pattern(shader) for each client -- this would avoid re-recording when multiple clients
     // share the same pattern.
-    HashMap<const RenderObject*, OwnPtr<PatternData> > m_patternMap;
+    HashMap<const RenderObject*, OwnPtr<PatternData>> m_patternMap;
 };
 
 }
 
 #endif