Oilpan: move RenderObjects off heap.

Source/core/animation/CompositorAnimationsTest.cpp

 /*
  * Copyright (c) 2013, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 238 matching lines @@
     void simulateFrame(double time)
     {
         m_document->animationClock().updateTime(time);
         m_document->compositorPendingAnimations().update(false);
         m_timeline->serviceAnimations(TimingUpdateForAnimationFrame);
     }
 };
 
 class RenderObjectProxy : public RenderObject {
 public:
-    static PassOwnPtrWillBeRawPtr<RenderObjectProxy> create(Node* node)
+    static PassOwnPtr<RenderObjectProxy> create(Node* node)
     {
-        return adoptPtrWillBeNoop(new RenderObjectProxy(node));
-    }
-
-    static void dispose(PassOwnPtrWillBeRawPtr<RenderObjectProxy> object)

[tkent, 2015/02/04 00:50:44]

Don't remove this function.  This is not specific to Oilpan, and we need to call
RenderObject::destroy().

[sof, 2015/02/04 08:44:31]

Added back again (the use of destroy() was added as part of fixing this test for
Oilpan, btw.)

-    {
-        object.leakPtr()->destroy();
+        return adoptPtr(new RenderObjectProxy(node));
     }
 
     const char* renderName() const override { return nullptr; }
     void layout() override { }
+
 private:
     explicit RenderObjectProxy(Node* node)
         : RenderObject(node)
     {
     }
 };
 
 // -----------------------------------------------------------------------
 // -----------------------------------------------------------------------
 
@@ skipping 914 matching lines @@
     result[0].clear();
 }
 
 TEST_F(AnimationCompositorAnimationsTest, CancelIncompatibleCompositorAnimations)
 {
     WebCompositorSupportMock mockCompositor;
     setCompositorForTesting(mockCompositor);
 
     RefPtrWillBePersistent<Element> element = m_document->createElement("shared", ASSERT_NO_EXCEPTION);
 
-    OwnPtrWillBePersistent<RenderObjectProxy> renderer = RenderObjectProxy::create(element.get());
+    OwnPtr<RenderObjectProxy> renderer = RenderObjectProxy::create(element.get());
     element->setRenderer(renderer.get());
 
     AnimatableValueKeyframeVector keyFrames;
     keyFrames.append(createDefaultKeyframe(CSSPropertyOpacity, AnimationEffect::CompositeReplace, 0.0).get());
     keyFrames.append(createDefaultKeyframe(CSSPropertyOpacity, AnimationEffect::CompositeReplace, 1.0).get());
     RefPtrWillBeRawPtr<AnimationEffect> animationEffect1 = AnimatableValueKeyframeEffectModel::create(keyFrames);
     RefPtrWillBeRawPtr<AnimationEffect> animationEffect2 = AnimatableValueKeyframeEffectModel::create(keyFrames);
 
     Timing timing;
     timing.iterationDuration = 1.f;
@@ skipping 19 matching lines @@
     player2->cancelIncompatibleAnimationsOnCompositor();
 
     EXPECT_FALSE(player1->hasActiveAnimationsOnCompositor());
     EXPECT_FALSE(player2->hasActiveAnimationsOnCompositor());
 
     simulateFrame(0);
     EXPECT_EQ(2U, element->activeAnimations()->players().size());
     simulateFrame(1.);
 
     element->setRenderer(nullptr);
-    RenderObjectProxy::dispose(renderer.release());
+    renderer = nullptr;
 
     player1.release();
     player2.release();
     Heap::collectAllGarbage();
     EXPECT_TRUE(element->activeAnimations()->players().isEmpty());
 }
 
 } // namespace blink