Lexical declarations should not be allowed in Statement

Lexical declarations should not be allowed in Statement

For example let and class should only be allowed inside function/block/script.

We have to continue to support const in statements in sloppy mode for backwards compatibility.

BUG=3831
LOG=Y
R=dslomov@chromium.org, adamk

Committed: https://crrev.com/13616615fd97f9cdde7ac93a883049a5f5122c82
Cr-Commit-Position: refs/heads/master@{#26337}

[arv (Not doing code reviews), 2015-01-23 17:52:03]

Add bug URL

[arv (Not doing code reviews), 2015-01-23 19:32:08]

Allow const in sloppy statements again

[arv (Not doing code reviews), 2015-01-23 19:52:17]

Update comment a bit

[arv (Not doing code reviews), 2015-01-23 19:53:03]

Update comment a bit

[arv (Not doing code reviews), 2015-01-23 19:53:54]

PTAL

[adamk, 2015-01-23 20:11:39]

Moving LET/CONST parsing out of ParseStatement creates some dead branches in
ParseVariableDeclarations(). I'm guessing we can just delete that code, possibly
replacing it with a few DCHECKs.

https://codereview.chromium.org/869293002/diff/80001/src/parser.cc
File src/parser.cc (right):

https://codereview.chromium.org/869293002/diff/80001/src/parser.cc#newcode2152
src/parser.cc:2152: if (var_context == kStatement) {
I believe this code is now unreachable...

https://codereview.chromium.org/869293002/diff/80001/src/parser.cc#newcode2172
src/parser.cc:2172: if (var_context == kStatement) {
...as is this.

https://codereview.chromium.org/869293002/diff/80001/src/parser.cc#newcode2451
src/parser.cc:2451: return nullptr;
Nit: the rest of the code in this file still uses "NULL"

https://codereview.chromium.org/869293002/diff/80001/src/preparser.cc
File src/preparser.cc (right):

https://codereview.chromium.org/869293002/diff/80001/src/preparser.cc#newcode450
src/preparser.cc:450: if (var_context != kSourceElement && var_context !=
kForStatement) {
Same dead code as in parser...

https://codereview.chromium.org/869293002/diff/80001/src/preparser.cc#newcode466
src/preparser.cc:466: if (var_context != kSourceElement && var_context !=
kForStatement) {
...and here too.

[arv (Not doing code reviews), 2015-01-23 21:03:12]

On 2015/01/23 20:11:39, adamk wrote:
> Moving LET/CONST parsing out of ParseStatement creates some dead branches in
> ParseVariableDeclarations(). I'm guessing we can just delete that code,
possibly
> replacing it with a few DCHECKs.
> 
> https://codereview.chromium.org/869293002/diff/80001/src/parser.cc
> File src/parser.cc (right):
> 
> https://codereview.chromium.org/869293002/diff/80001/src/parser.cc#newcode2152
> src/parser.cc:2152: if (var_context == kStatement) {
> I believe this code is now unreachable...
> 
> https://codereview.chromium.org/869293002/diff/80001/src/parser.cc#newcode2172
> src/parser.cc:2172: if (var_context == kStatement) {
> ...as is this.
> 
> https://codereview.chromium.org/869293002/diff/80001/src/parser.cc#newcode2451
> src/parser.cc:2451: return nullptr;
> Nit: the rest of the code in this file still uses "NULL"
> 
> https://codereview.chromium.org/869293002/diff/80001/src/preparser.cc
> File src/preparser.cc (right):
> 
>
https://codereview.chromium.org/869293002/diff/80001/src/preparser.cc#newcode450
> src/preparser.cc:450: if (var_context != kSourceElement && var_context !=
> kForStatement) {
> Same dead code as in parser...
> 
>
https://codereview.chromium.org/869293002/diff/80001/src/preparser.cc#newcode466
> src/preparser.cc:466: if (var_context != kSourceElement && var_context !=
> kForStatement) {
> ...and here too.

Good catch. I should probably also ensure that I use those old error messages.

[arv (Not doing code reviews), 2015-01-30 02:10:05]

Code review feedback

[arv (Not doing code reviews), 2015-01-30 02:16:22]

Remove unused error messages

[arv (Not doing code reviews), 2015-01-30 02:18:48]

PTAL

[adamk, 2015-01-30 02:57:51]

lgtm

[arv (Not doing code reviews), 2015-01-30 03:08:05]

The CQ bit was checked by arv@chromium.org

[commit-bot: I haz the power, 2015-01-30 03:08:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/869293002/120001

[commit-bot: I haz the power, 2015-01-30 03:10:08]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2015-01-30 03:10:27]

Patchset 7 (id:??) landed as
https://crrev.com/13616615fd97f9cdde7ac93a883049a5f5122c82
Cr-Commit-Position: refs/heads/master@{#26337}