Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 869253002: Aria table row and column headers are not exposed in accessibility (Closed)

Created:
5 years, 11 months ago by k.czech
Modified:
5 years, 11 months ago
Reviewers:
dmazzoni
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Aria table row and column headers are not exposed in accessibility Aria table row and column headers should also be exposed in accessibility as in html tables. BUG=451047 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189033

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -1 line) Patch
A LayoutTests/accessibility/aria-tables.html View 1 chunk +48 lines, -0 lines 1 comment Download
A LayoutTests/accessibility/aria-tables-expected.txt View 1 chunk +48 lines, -0 lines 0 comments Download
M Source/modules/accessibility/AXARIAGridCell.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/modules/accessibility/AXARIAGridCell.cpp View 2 chunks +23 lines, -0 lines 0 comments Download
M Source/modules/accessibility/AXTableCell.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
k.czech
It should go in after https://codereview.chromium.org/807173005/. It seems this patch may touch some browser's content ...
5 years, 11 months ago (2015-01-23 15:19:39 UTC) #2
k.czech
On 2015/01/23 15:19:39, k.czech wrote: > It should go in after https://codereview.chromium.org/807173005/. > It seems ...
5 years, 11 months ago (2015-01-23 15:21:22 UTC) #3
dmazzoni
lgtm https://codereview.chromium.org/869253002/diff/1/LayoutTests/accessibility/aria-tables.html File LayoutTests/accessibility/aria-tables.html (right): https://codereview.chromium.org/869253002/diff/1/LayoutTests/accessibility/aria-tables.html#newcode25 LayoutTests/accessibility/aria-tables.html:25: function buildAccessibilityTree(accessibilityObject, i) { We're using buildAccessibilityTree in ...
5 years, 11 months ago (2015-01-23 19:02:06 UTC) #4
k.czech
On 2015/01/23 19:02:06, dmazzoni wrote: > lgtm > > https://codereview.chromium.org/869253002/diff/1/LayoutTests/accessibility/aria-tables.html > File LayoutTests/accessibility/aria-tables.html (right): > ...
5 years, 11 months ago (2015-01-24 21:49:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/869253002/1
5 years, 11 months ago (2015-01-27 13:14:53 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 14:26:59 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189033

Powered by Google App Engine
This is Rietveld 408576698