Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1119)

Issue 8692012: net: replace DnsRRResoler with TransportSecurityState in plumbing. (Closed)

Created:
9 years ago by agl
Modified:
9 years ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

net: replace DnsRRResoler with TransportSecurityState in plumbing. The DnsRRResoler has served its time and I don't have any further plans for it. The TransportSecurityState will be used (in a future CL) to enforce public key pinning at certificate verification time. Currently we only enforce it in url_request_http_job.cc which means that we've already sent the HTTP request (inc cookies) by the time we catch the problem. This was expeditious while we fixed some other issues, but it's time to fix it. BUG=none TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113410

Patch Set 1 #

Total comments: 1

Patch Set 2 : ... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -125 lines) Patch
M chrome/browser/io_thread.h View 1 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/io_thread.cc View 1 5 chunks +9 lines, -3 lines 0 comments Download
M chrome/browser/net/connection_tester.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/net/connection_tester_unittest.cc View 1 4 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_io_data.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/profiles/profile_impl_io_data.cc View 1 2 chunks +1 line, -5 lines 0 comments Download
M chrome/service/net/service_url_request_context.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M content/shell/shell_url_request_context_getter.cc View 1 2 chunks +1 line, -4 lines 0 comments Download
M jingle/notifier/base/proxy_resolving_client_socket.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/http/disk_cache_based_ssl_host_info_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M net/http/http_cache.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M net/http/http_cache.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M net/http/http_network_session.h View 4 chunks +3 lines, -3 lines 0 comments Download
M net/http/http_network_session.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/client_socket_pool_manager_impl.h View 4 chunks +3 lines, -3 lines 0 comments Download
M net/socket/client_socket_pool_manager_impl.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M net/socket/ssl_client_socket.h View 1 3 chunks +4 lines, -24 lines 0 comments Download
M net/socket/ssl_client_socket_nss.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M net/socket/ssl_client_socket_pool.h View 3 chunks +3 lines, -3 lines 0 comments Download
M net/socket/ssl_client_socket_pool.cc View 1 3 chunks +2 lines, -5 lines 0 comments Download
M net/socket/ssl_host_info.h View 1 3 chunks +0 lines, -10 lines 0 comments Download
M net/socket/ssl_host_info.cc View 1 2 chunks +1 line, -15 lines 0 comments Download
M net/url_request/url_request_context.h View 3 chunks +0 lines, -10 lines 0 comments Download
M net/url_request/url_request_context.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M net/url_request/url_request_context_storage.h View 3 chunks +0 lines, -3 lines 0 comments Download
M net/url_request/url_request_context_storage.cc View 2 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
agl
9 years ago (2011-11-29 22:39:53 UTC) #1
agl
poke.
9 years ago (2011-12-05 21:17:05 UTC) #2
willchan no longer on Chromium
Ooops, looking now. On Mon, Dec 5, 2011 at 1:17 PM, Adam Langley <agl@chromium.org> wrote: ...
9 years ago (2011-12-05 21:19:08 UTC) #3
willchan no longer on Chromium
lgtm http://codereview.chromium.org/8692012/diff/1/jingle/notifier/base/proxy_resolving_client_socket.cc File jingle/notifier/base/proxy_resolving_client_socket.cc (right): http://codereview.chromium.org/8692012/diff/1/jingle/notifier/base/proxy_resolving_client_socket.cc#newcode51 jingle/notifier/base/proxy_resolving_client_socket.cc:51: // transport_security_state is NULL because it's not thread ...
9 years ago (2011-12-05 21:22:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/agl@chromium.org/8692012/6001
9 years ago (2011-12-06 21:09:16 UTC) #5
commit-bot: I haz the power
Try job failure for 8692012-6001 (retry) on linux_clang for step "compile" (clobber build). It's a ...
9 years ago (2011-12-06 21:50:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/agl@chromium.org/8692012/6001
9 years ago (2011-12-07 15:56:14 UTC) #7
commit-bot: I haz the power
9 years ago (2011-12-07 17:47:29 UTC) #8
Change committed as 113410

Powered by Google App Engine
This is Rietveld 408576698