Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: chrome/browser/ui/views/extensions/extension_dialog.cc

Issue 8692006: Fix for cant reopen file dialog after close it by x button or alt+f4 (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Remove redundant comment. Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/extensions/extension_dialog.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/extensions/extension_dialog.cc
diff --git a/chrome/browser/ui/views/extensions/extension_dialog.cc b/chrome/browser/ui/views/extensions/extension_dialog.cc
index 32bc344759030129f11a4c160ccd3ff75e0db5aa..54b7d2b159cfbd1fa0a5cfbb86e5602b0115d557 100644
--- a/chrome/browser/ui/views/extensions/extension_dialog.cc
+++ b/chrome/browser/ui/views/extensions/extension_dialog.cc
@@ -113,9 +113,6 @@ void ExtensionDialog::Close() {
if (!window_)
return;
- if (observer_)
- observer_->ExtensionDialogIsClosing(this);
-
window_->Close();
window_ = NULL;
}
@@ -139,6 +136,11 @@ string16 ExtensionDialog::GetWindowTitle() const {
return window_title_;
}
+void ExtensionDialog::WindowClosing() {
+ if (observer_)
+ observer_->ExtensionDialogIsClosing(this);
+}
+
void ExtensionDialog::DeleteDelegate() {
// The window has finished closing. Allow ourself to be deleted.
Release();
« no previous file with comments | « chrome/browser/ui/views/extensions/extension_dialog.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698