Fix for cant reopen file dialog after close it by x button or alt+f4

chrome/browser/ui/views/extensions/extension_dialog.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/extensions/extension_dialog.h"
 
 #include "chrome/browser/extensions/extension_host.h"
 #include "chrome/browser/extensions/extension_process_manager.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
@@ skipping 121 matching lines @@
 }
 
 bool ExtensionDialog::ShouldShowWindowTitle() const {
   return !window_title_.empty();
 }
 
 string16 ExtensionDialog::GetWindowTitle() const {
   return window_title_;
 }
 
+void ExtensionDialog::WindowClosing() {
+  Close();

[flackr, 2011/11/28 16:46:55]

This doesn't seem correct to me. The window is already closing, and this might
even be called in response to a a call to Close. Instead you should probably
move the following code from ExtensionDialog::Close to here:
  if (observer_)
    observer_->ExtensionDialogIsClosing(this);

Just make sure that this method is called when the dialog is closed using
ExtensionDialog::Close.

[bshe, 2011/11/28 18:40:26]

Done

On 2011/11/28 16:46:55, flackr wrote:

+}
+
 void ExtensionDialog::DeleteDelegate() {
   // The window has finished closing.  Allow ourself to be deleted.
   Release();
 }
 
 views::Widget* ExtensionDialog::GetWidget() {
   return extension_host_->view()->GetWidget();
 }
 
 const views::Widget* ExtensionDialog::GetWidget() const {
@@ skipping 15 matching lines @@
       // If we aren't the host of the popup, then disregard the notification.
       if (content::Details<ExtensionHost>(host()) != details)
         return;
       Close();
       break;
     default:
       NOTREACHED() << L"Received unexpected notification";
       break;
   }
 }