Issue 8692003: set type 'settings' to 'none' in gyp file in case using the system lib

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8692003: set type 'settings' to 'none' in gyp file in case using the system lib (Closed)

Created:
9 years, 1 month ago by Robert Nagy

Modified:
9 years, 1 month ago

Reviewers:
Mark Mentovai

Base URL:
http://git.chromium.org/chromium/deps/speex.git@master

Visibility:
Public.

More Reviews

Description

set type 'settings' to 'none' in gyp file in case using the system lib Contributed by robert.nagy@gmail.com BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111570

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	speex.gyp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Robert Nagy

On 2011/11/24 14:22:44, Mark Mentovai wrote: > LGTM and CQ I guess this will have ...

9 years, 1 month ago (2011-11-24 15:54:47 UTC) #3

Ryan Sleevi

On 2011/11/24 15:54:47, Robert Nagy wrote: > On 2011/11/24 14:22:44, Mark Mentovai wrote: > > ...

9 years, 1 month ago (2011-11-24 23:12:26 UTC) #4

Ryan Sleevi

9 years, 1 month ago (2011-11-25 00:46:10 UTC) #5

On 2011/11/24 23:12:26, Ryan Sleevi wrote:
> On 2011/11/24 15:54:47, Robert Nagy wrote:
> > On 2011/11/24 14:22:44, Mark Mentovai wrote:
> > > LGTM and CQ
> > 
> > I guess this will have to go in by hand?
> 
> Yeah, the CQ doesn't currently map the Base URL for this CL.
> 
> Source is at
>
http://codesearch.google.com/codesearch#OAMlx_jo-ck/tools/commit-queue/projec...

Landed as r111570

You will need to submit an update to DEPS to pull in the new revision

Expand Messages | Collapse Messages