Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java

Issue 869193008: [Android] Change enhanced bookmark top level definitions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: updated tests Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/javatests/src/org/chromium/chrome/browser/BookmarksBridgeTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java
index 479ec7ccfbff3854f1e39f0965d43c2ff79fde8e..b31f59732f4886c0bcf22ea3ca3bbdbed9f1de0c 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java
@@ -225,7 +225,7 @@ public class BookmarksBridge {
}
/**
- * @return The top level folder's parents, which are root node, mobile node, and other node.
+ * @return The top level folder's parents.
*/
public List<BookmarkId> getTopLevelFolderParentIDs() {
assert mIsNativeBookmarkModelLoaded;
@@ -238,9 +238,7 @@ public class BookmarksBridge {
* @param getSpecial Whether special top folders should be returned.
* @param getNormal Whether normal top folders should be returned.
* @return The top level folders. Note that special folders come first and normal top folders
- * will be in the alphabetical order. Special top folders are managed bookmark and
- * partner bookmark. Normal top folders are desktop permanent folder, and the
- * sub-folders of mobile permanent folder and others permanent folder.
+ * will be in the alphabetical order.
*/
public List<BookmarkId> getTopLevelFolderIDs(boolean getSpecial, boolean getNormal) {
assert mIsNativeBookmarkModelLoaded;
@@ -250,17 +248,6 @@ public class BookmarksBridge {
}
/**
- * @return The uncategorized bookmark IDs. They are direct descendant bookmarks of mobile and
- * other folders.
- */
- public List<BookmarkId> getUncategorizedBookmarkIDs() {
- assert mIsNativeBookmarkModelLoaded;
- List<BookmarkId> result = new ArrayList<BookmarkId>();
- nativeGetUncategorizedBookmarkIDs(mNativeBookmarksBridge, result);
- return result;
- }
-
- /**
* Populates folderList with BookmarkIds of folders users can move bookmarks
* to and all folders have corresponding depth value in depthList. Folders
* having depths of 0 will be shown as top-layered folders. These include
@@ -702,8 +689,6 @@ public class BookmarksBridge {
List<BookmarkId> bookmarksList);
private native void nativeGetTopLevelFolderIDs(long nativeBookmarksBridge, boolean getSpecial,
boolean getNormal, List<BookmarkId> bookmarksList);
- private native void nativeGetUncategorizedBookmarkIDs(long nativeBookmarksBridge,
- List<BookmarkId> bookmarksList);
private native void nativeGetAllFoldersWithDepths(long nativeBookmarksBridge,
List<BookmarkId> folderList, List<Integer> depthList);
private native BookmarkId nativeGetMobileFolderId(long nativeBookmarksBridge);
« no previous file with comments | « no previous file | chrome/android/javatests/src/org/chromium/chrome/browser/BookmarksBridgeTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698