Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 869193005: Set up a network service bootstrap. (Closed)

Created:
5 years, 11 months ago by ppi
Modified:
5 years, 11 months ago
Reviewers:
jamesr
CC:
mojo-reviews_chromium.org, yzshen+watch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Set up a network service bootstrap. This adds a script to download network service binaries identified by a versioned stamp kept in services/network/VERSION and adds a DEPS hook to run it at gclient --sync. BUG=450356 R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/bd599f305854b469c366ba2ce00464660213df6a

Patch Set 1 #

Patch Set 2 : Extract gs.py. #

Total comments: 4

Patch Set 3 : Address James's comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -0 lines) Patch
M .gitignore View 1 chunk +1 line, -0 lines 0 comments Download
M DEPS View 1 chunk +7 lines, -0 lines 0 comments Download
A services/network/BUILD.gn View 1 2 1 chunk +20 lines, -0 lines 0 comments Download
A services/network/VERSION View 1 chunk +1 line, -0 lines 0 comments Download
A services/network/download_network_service.py View 1 2 1 chunk +69 lines, -0 lines 0 comments Download
A tools/gs.py View 1 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
ppi
Hi James, ptal.
5 years, 11 months ago (2015-01-23 21:34:02 UTC) #2
jamesr
lgtm https://codereview.chromium.org/869193005/diff/90001/services/network/BUILD.gn File services/network/BUILD.gn (right): https://codereview.chromium.org/869193005/diff/90001/services/network/BUILD.gn#newcode13 services/network/BUILD.gn:13: "prebuilt/linux-x64/$filename", can we assert(is_linux) here so if someone ...
5 years, 11 months ago (2015-01-23 23:15:01 UTC) #7
ppi
Thanks! https://codereview.chromium.org/869193005/diff/90001/services/network/BUILD.gn File services/network/BUILD.gn (right): https://codereview.chromium.org/869193005/diff/90001/services/network/BUILD.gn#newcode13 services/network/BUILD.gn:13: "prebuilt/linux-x64/$filename", On 2015/01/23 23:15:00, jamesr wrote: > can ...
5 years, 11 months ago (2015-01-23 23:24:36 UTC) #8
ppi
5 years, 11 months ago (2015-01-23 23:25:18 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:2) manually as
bd599f305854b469c366ba2ce00464660213df6a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698