Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: extensions/browser/guest_view/web_view/web_view_guest.cc

Issue 869193004: <webview>: Reuse GuestViewBase::HandleKeyboardEvent code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/guest_view/web_view/web_view_guest.cc
diff --git a/extensions/browser/guest_view/web_view/web_view_guest.cc b/extensions/browser/guest_view/web_view/web_view_guest.cc
index 7176e10185b83dcd75821dfd93743c0c330daa64..dc0a0e047e2810b1e14308ea2df21bdbf742545f 100644
--- a/extensions/browser/guest_view/web_view/web_view_guest.cc
+++ b/extensions/browser/guest_view/web_view/web_view_guest.cc
@@ -434,20 +434,10 @@ bool WebViewGuest::HandleContextMenu(
void WebViewGuest::HandleKeyboardEvent(
WebContents* source,
const content::NativeWebKeyboardEvent& event) {
- if (!attached())
- return;
-
if (HandleKeyboardShortcuts(event))
return;
- // Send the unhandled keyboard events back to the embedder to reprocess them.
- // TODO(fsamuel): This introduces the possibility of out-of-order keyboard
- // events because the guest may be arbitrarily delayed when responding to
- // keyboard events. In that time, the embedder may have received and processed
- // additional key events. This needs to be fixed as soon as possible.
- // See http://crbug.com/229882.
- embedder_web_contents()->GetDelegate()->HandleKeyboardEvent(
- web_contents(), event);
+ GuestViewBase::HandleKeyboardEvent(source, event);
}
void WebViewGuest::LoadProgressChanged(content::WebContents* source,

Powered by Google App Engine
This is Rietveld 408576698