Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Unified Diff: tools/telemetry/telemetry/page/page_test.py

Issue 869163003: [Cleanup] Remove Screenshot measurement test from telemetry (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/measurements/screenshot_unittest.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/page/page_test.py
diff --git a/tools/telemetry/telemetry/page/page_test.py b/tools/telemetry/telemetry/page/page_test.py
index d66167882a07f6e368080cdb5edccce3612de434..646a5f4be2b213803e17687f272417373270f9d5 100644
--- a/tools/telemetry/telemetry/page/page_test.py
+++ b/tools/telemetry/telemetry/page/page_test.py
@@ -47,19 +47,13 @@ class PageTest(object):
subclasses to run.
discard_first_run: Discard the first run of this page. This is
usually used with page_repeat and pageset_repeat options.
- is_action_name_to_run_optional: Determines what to do if
- action_name_to_run is not empty but the page doesn't have that
- action. The page will run (without any action) if
- is_action_name_to_run_optional is True, otherwise the page
- will fail.
"""
def __init__(self,
action_name_to_run='',
needs_browser_restart_after_each_page=False,
discard_first_result=False,
- clear_cache_before_each_run=False,
- is_action_name_to_run_optional=False):
+ clear_cache_before_each_run=False):
super(PageTest, self).__init__()
self.options = None
@@ -74,7 +68,6 @@ class PageTest(object):
self._discard_first_result = discard_first_result
self._clear_cache_before_each_run = clear_cache_before_each_run
self._close_tabs_before_run = True
- self._is_action_name_to_run_optional = is_action_name_to_run_optional
@property
def is_multi_tab_test(self):
@@ -156,7 +149,7 @@ class PageTest(object):
def CanRunForPage(self, page): # pylint: disable=W0613
"""Override to customize if the test can be ran for the given page."""
- if self._action_name_to_run and not self._is_action_name_to_run_optional:
+ if self._action_name_to_run:
return hasattr(page, self._action_name_to_run)
return True
« no previous file with comments | « tools/perf/measurements/screenshot_unittest.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698