Support migrating multi-install Chrome to single-install.

chrome/installer/util/installation_validator.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Implementation of the installation validator.
 
 #include "chrome/installer/util/installation_validator.h"
 
 #include <algorithm>
 #include <set>
@@ skipping 374 matching lines @@
       LOG(ERROR) << "Chrome Binaries are missing \"-chromeframe\" in channel"
                     " name: \"" << channel.value() << "\"";
     }
   } else if (channel.IsChromeFrame()) {
     *is_valid = false;
     LOG(ERROR) << "Chrome Binaries have \"-chromeframe\" in channel name, yet "
                   "Chrome Frame is not installed multi: \"" << channel.value()
                << "\"";
   }
 
-  // ap must have -applauncher iff Chrome App Launcher is installed multi
-  const ProductState* app_host_state = machine_state.GetProductState(
-      system_install, BrowserDistribution::CHROME_APP_HOST);
-  if (app_host_state != NULL) {
-    if (!app_host_state->is_multi_install()) {
-      *is_valid = false;
-      LOG(ERROR) << "Chrome App Launcher is installed in non-multi mode.";
-    }
-    if (!channel.IsAppLauncher()) {
-      *is_valid = false;
-      LOG(ERROR) << "Chrome Binaries are missing \"-applauncher\" in channel"
-                    " name: \"" << channel.value() << "\"";
-    }
-  } else if (channel.IsAppLauncher()) {
+  // ap must not have -applauncher.
+  if (channel.IsAppLauncher()) {

[robertshield, 2015/01/23 22:45:30]

isn't applauncher dead again?

[grt (UTC plus 2), 2015/01/24 02:25:16]

huangs@ is removing heroic swaths of code in
https://codereview.chromium.org/811283002/. I'll hold off on landing this until
after his so that I pay the price of the merge conflicts. :-)

     *is_valid = false;
-    LOG(ERROR) << "Chrome Binaries have \"-applauncher\" in channel name, yet "
-                  "Chrome App Launcher is not installed: \"" << channel.value()
-               << "\"";
+    LOG(ERROR) << "Chrome Binaries have \"-applauncher\" in channel name: \""
+               << channel.value() << "\"";
   }
 
-  // Chrome, Chrome Frame, or App Host must be present
-  if (chrome_state == NULL && cf_state == NULL && app_host_state == NULL) {
+  // Chrome or Chrome Frame must be present
+  if (chrome_state == NULL && cf_state == NULL) {
     *is_valid = false;
     LOG(ERROR) << "Chrome Binaries are present with no other products.";
   }
 
   // Chrome must be multi-install if present.
   if (chrome_state != NULL && !chrome_state->is_multi_install()) {
     *is_valid = false;
     LOG(ERROR)
         << "Chrome Binaries are present yet Chrome is not multi-install.";
   }
 
-  // Chrome Frame must be multi-install if Chrome & App Host are not present.
-  if (cf_state != NULL && app_host_state == NULL && chrome_state == NULL &&
+  // Chrome Frame must be multi-install if Chrome is not present.
+  if (cf_state != NULL && chrome_state == NULL &&
       !cf_state->is_multi_install()) {
     *is_valid = false;
-    LOG(ERROR) << "Chrome Binaries are present without Chrome nor App Launcher "
-               << "yet Chrome Frame is not multi-install.";
+    LOG(ERROR) << "Chrome Binaries are present without Chrome yet Chrome Frame "
+                  "is not multi-install.";
   }
 
   ChromeBinariesRules binaries_rules;
   ProductContext ctx(machine_state, system_install, binaries_state,
                      binaries_rules);
 
   ValidateBinariesCommands(ctx, is_valid);
 
   ValidateUsageStats(ctx, is_valid);
 }
@@ skipping 255 matching lines @@
                                     BrowserDistribution::CHROME_BROWSER);
   if (product_state != NULL) {
     ChromeRules chrome_rules;
     ValidateProduct(machine_state, system_level, *product_state,
                     chrome_rules, &rock_on);
     *type = static_cast<InstallationType>(
         *type | (product_state->is_multi_install() ?
                  ProductBits::CHROME_MULTI :
                  ProductBits::CHROME_SINGLE));
   }
+  // Usage of the app launcher is tracked alongside Chrome.
+  const ProductState* launcher_state =
+      machine_state.GetProductState(system_level,
+                                    BrowserDistribution::CHROME_APP_HOST);
+  BrowserDistribution* chrome_dist =
+      BrowserDistribution::GetSpecificDistribution(
+          BrowserDistribution::CHROME_BROWSER);
+  if (!launcher_state) {
+    LOG_IF(ERROR, product_state)
+        << "App launcher is not installed with "
+        << chrome_dist->GetDisplayName();
+  } else {
+    LOG_IF(ERROR, !product_state)
+        << "App launcher is installed without "
+        << chrome_dist->GetDisplayName();
+  }
 
   // Is Chrome Frame installed?
   product_state =
       machine_state.GetProductState(system_level,
                                     BrowserDistribution::CHROME_FRAME);
   if (product_state != NULL) {
     ChromeFrameRules chrome_frame_rules;
     ValidateProduct(machine_state, system_level, *product_state,
                     chrome_frame_rules, &rock_on);
     int cf_bit = !product_state->is_multi_install() ?
         ProductBits::CHROME_FRAME_SINGLE :
         ProductBits::CHROME_FRAME_MULTI;
     *type = static_cast<InstallationType>(*type | cf_bit);
   }
 
-  // Is Chrome App Host installed?
-  product_state =
-      machine_state.GetProductState(system_level,
-                                    BrowserDistribution::CHROME_APP_HOST);
-  if (product_state != NULL) {
-    ChromeAppHostRules chrome_app_host_rules;
-    ValidateProduct(machine_state, system_level, *product_state,
-                    chrome_app_host_rules, &rock_on);
-    *type = static_cast<InstallationType>(*type | ProductBits::CHROME_APP_HOST);
-    if (!product_state->is_multi_install()) {
-      LOG(ERROR) << "Chrome App Launcher must always be multi-install.";
-      rock_on = false;
-    }
-  }
-
   DCHECK_NE(std::find(&kInstallationTypes[0],
                       &kInstallationTypes[arraysize(kInstallationTypes)],
                       *type),
             &kInstallationTypes[arraysize(kInstallationTypes)])
       << "Invalid combination of products found on system (" << *type << ")";
 
   return rock_on;
 }
 
 // static
 bool InstallationValidator::ValidateInstallationType(bool system_level,
                                                      InstallationType* type) {
   DCHECK(type);
   InstallationState machine_state;
 
   machine_state.Initialize();
 
   return ValidateInstallationTypeForState(machine_state, system_level, type);
 }
 
 }  // namespace installer